extensions/common/api/externs_checker.py - Issue 1925273002: [Closure Externs] Fix presubmit check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/externs_checker.py

Issue 1925273002: [Closure Externs] Fix presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/api/externs_checker.py

diff --git a/extensions/common/api/externs_checker.py b/extensions/common/api/externs_checker.py

index fd60fdd87df4901e4679f3d7e25845caf1d0523d..74906bd4883a1cb622ef0a18e434d89db9d3d833 100644

--- a/extensions/common/api/externs_checker.py

+++ b/extensions/common/api/externs_checker.py

@@ -18,7 +18,8 @@ class ExternsChecker(object):

def RunChecks(self):

bad_files = []

- affected = [f.AbsoluteLocalPath() for f in self._input_api.AffectedFiles()]

+ affected = [f.AbsoluteLocalPath() for f in

+ self._input_api.change.AffectedFiles()]

for path in affected:

pair = self._api_pairs.get(path)

if pair != None and pair not in affected:

« no previous file with comments | « PRESUBMIT_test_mocks.py ('k') | extensions/common/api/externs_checker_test.py » ('j') | no next file with comments »