Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1925183005: Fix usage of tracing within Skia, for renderer processes.

Created:
4 years, 7 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix usage of tracing within Skia, for renderer processes. Skia has a default implementation of this instance, so the check would always fail. Broken by https://codereview.chromium.org/1408583002 R=mtklein BUG=608022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M skia/ext/event_tracer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
bsalomon
I don't think it will allow you to land but lgtm.
4 years, 4 months ago (2016-07-26 21:27:22 UTC) #3
mtklein_C
ditto, lgtm
4 years, 4 months ago (2016-07-26 22:47:47 UTC) #5
Stephen White
LGTM if it helps. IWBN to land this (if correct).
4 years, 4 months ago (2016-08-09 14:37:13 UTC) #6
oystein (OOO til 10th of July)
On 2016/08/09 14:37:13, Stephen White wrote: > LGTM if it helps. IWBN to land this ...
4 years, 4 months ago (2016-08-09 17:16:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1925183005/1
4 years, 4 months ago (2016-08-09 17:16:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/204395)
4 years, 4 months ago (2016-08-09 17:41:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1925183005/1
4 years, 4 months ago (2016-08-22 15:59:43 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:22:56 UTC) #15
Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Powered by Google App Engine
This is Rietveld 408576698