Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 1408583002: Enable Skia tracing in browser process (Closed)

Created:
5 years, 2 months ago by Lof
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Skia tracing in browser process Skia tracing works fine, but only in renderer processes. ( https://codereview.chromium.org/153063002 ) Now Skia tracing also works in browser process. BUG=543149 R=nduca, bsalomon, humper, enne Committed: https://crrev.com/106533b1571a76b2c23e99dff1aa060f6db01602 Cr-Commit-Position: refs/heads/master@{#355082}

Patch Set 1 #

Patch Set 2 : Single process mode fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/browser_main_loop.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M skia/ext/event_tracer_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
Lof
5 years, 2 months ago (2015-10-14 15:23:55 UTC) #2
bsalomon
On 2015/10/14 15:23:55, Lof wrote: lgtm
5 years, 2 months ago (2015-10-14 15:26:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408583002/1
5 years, 2 months ago (2015-10-14 20:57:15 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-14 20:57:17 UTC) #7
Lof
On 2015/10/14 15:26:58, bsalomon wrote: > On 2015/10/14 15:23:55, Lof wrote: > > lgtm It ...
5 years, 2 months ago (2015-10-14 21:36:24 UTC) #8
enne (OOO)
+sievers
5 years, 2 months ago (2015-10-19 21:25:19 UTC) #10
no sievers
lgtm
5 years, 2 months ago (2015-10-19 21:31:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408583002/1
5 years, 2 months ago (2015-10-20 07:54:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/128775)
5 years, 2 months ago (2015-10-20 08:25:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408583002/20001
5 years, 2 months ago (2015-10-20 16:03:43 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 17:05:56 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 17:06:42 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/106533b1571a76b2c23e99dff1aa060f6db01602
Cr-Commit-Position: refs/heads/master@{#355082}

Powered by Google App Engine
This is Rietveld 408576698