arc_bridge: Add more logging, plus cleanup

arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also a couple of small changes:

* Clean up some confusing logging statements.
* Add a small delay to reconnects so that the container can
  finish cleaning up in case it was doing so.

BUG=606081
TEST=components_unittests

Committed: https://crrev.com/e143a0260007413b48e82690fdf455efbe836789
Cr-Commit-Position: refs/heads/master@{#391434}

[Luis Héctor Chávez, 2016-04-28 23:34:11]

Description was changed from

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG entries
and promote a couple of critical ones from VLOG to LOG(INFO). Also clean
up some confusing logging statements.

BUG=606081
TEST=components_unittests
==========

to

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also clean up some confusing logging statements.

BUG=606081
TEST=components_unittests
==========

[Luis Héctor Chávez, 2016-04-28 23:44:33]

lhchavez@chromium.org changed reviewers:
+ elijahtaylor@chromium.org, yusukes@chromium.org

[Luis Héctor Chávez, 2016-04-28 23:44:34]

PTAL

elijahtaylor: components/arc
yusukes: chrome/browser/chromeos/arc

[Yusuke Sato, 2016-04-29 00:28:41]

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service_impl.cc (right):

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.cc:117:
base::MessageLoop::current()->task_runner()->PostDelayedTask(
What's the purpose of this change? Please mention this in the CL description.

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.cc:120: base::TimeDelta::FromSeconds(5));
Can you name the constant?

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service_impl.h (right):

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.h:31: ~ArcBridgeServiceImpl() override =
default;
Please move '= default' to the .cc side. Try jobs are failing.

[Luis Héctor Chávez, 2016-04-29 20:23:05]

Description was changed from

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also clean up some confusing logging statements.

BUG=606081
TEST=components_unittests
==========

to

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also a couple of small changes:

* Clean up some confusing logging statements.
* Add a small delay to reconnects so that the container can
  finish cleaning up in case it was doing so.

BUG=606081
TEST=components_unittests
==========

[Luis Héctor Chávez, 2016-04-29 20:23:15]

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service_impl.cc (right):

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.cc:117:
base::MessageLoop::current()->task_runner()->PostDelayedTask(
On 2016/04/29 00:28:41, Yusuke Sato wrote:
> What's the purpose of this change? Please mention this in the CL description.

Done, and added a comment.

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.cc:120: base::TimeDelta::FromSeconds(5));
On 2016/04/29 00:28:41, Yusuke Sato wrote:
> Can you name the constant?

Done.

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service_impl.h (right):

https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_impl.h:31: ~ArcBridgeServiceImpl() override =
default;
On 2016/04/29 00:28:41, Yusuke Sato wrote:
> Please move '= default' to the .cc side. Try jobs are failing.

Done.

[Yusuke Sato, 2016-04-29 20:34:01]

On 2016/04/29 20:23:15, Luis Héctor Chávez wrote:
>
https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
> File components/arc/arc_bridge_service_impl.cc (right):
> 
>
https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
> components/arc/arc_bridge_service_impl.cc:117:
> base::MessageLoop::current()->task_runner()->PostDelayedTask(
> On 2016/04/29 00:28:41, Yusuke Sato wrote:
> > What's the purpose of this change? Please mention this in the CL
description.
> 
> Done, and added a comment.
> 
>
https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
> components/arc/arc_bridge_service_impl.cc:120:
base::TimeDelta::FromSeconds(5));
> On 2016/04/29 00:28:41, Yusuke Sato wrote:
> > Can you name the constant?
> 
> Done.
> 
>
https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
> File components/arc/arc_bridge_service_impl.h (right):
> 
>
https://codereview.chromium.org/1925183004/diff/20001/components/arc/arc_brid...
> components/arc/arc_bridge_service_impl.h:31: ~ArcBridgeServiceImpl() override
=
> default;
> On 2016/04/29 00:28:41, Yusuke Sato wrote:
> > Please move '= default' to the .cc side. Try jobs are failing.
> 
> Done.

lgtm

[Luis Héctor Chávez, 2016-05-03 19:23:20]

gentle ping

[elijahtaylor1, 2016-05-04 00:40:00]

lgtm

[Luis Héctor Chávez, 2016-05-04 00:43:58]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:44:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925183004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925183004/80001

[commit-bot: I haz the power, 2016-05-04 00:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:52:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Luis Héctor Chávez, 2016-05-04 02:57:52]

lhchavez@chromium.org changed reviewers:
+ cernekee@chromium.org

[Luis Héctor Chávez, 2016-05-04 02:57:53]

cernekee PTAL components/arc/net

[Kevin Cernekee, 2016-05-04 03:09:22]

lgtm

[Luis Héctor Chávez, 2016-05-04 03:09:43]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2016-05-04 03:09:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925183004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925183004/80001

[commit-bot: I haz the power, 2016-05-04 03:16:08]

Description was changed from

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also a couple of small changes:

* Clean up some confusing logging statements.
* Add a small delay to reconnects so that the container can
  finish cleaning up in case it was doing so.

BUG=606081
TEST=components_unittests
==========

to

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also a couple of small changes:

* Clean up some confusing logging statements.
* Add a small delay to reconnects so that the container can
  finish cleaning up in case it was doing so.

BUG=606081
TEST=components_unittests
==========

[commit-bot: I haz the power, 2016-05-04 03:16:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-04 03:17:58]

Description was changed from

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also a couple of small changes:

* Clean up some confusing logging statements.
* Add a small delay to reconnects so that the container can
  finish cleaning up in case it was doing so.

BUG=606081
TEST=components_unittests
==========

to

==========
arc_bridge: Add more logging, plus cleanup

In order to better troubleshoot startup issues, add more VLOG
entries and promote a couple of critical ones from VLOG(1) to
VLOG(0). Also a couple of small changes:

* Clean up some confusing logging statements.
* Add a small delay to reconnects so that the container can
  finish cleaning up in case it was doing so.

BUG=606081
TEST=components_unittests

Committed: https://crrev.com/e143a0260007413b48e82690fdf455efbe836789
Cr-Commit-Position: refs/heads/master@{#391434}
==========

[commit-bot: I haz the power, 2016-05-04 03:17:59]

Patchset 5 (id:??) landed as
https://crrev.com/e143a0260007413b48e82690fdf455efbe836789
Cr-Commit-Position: refs/heads/master@{#391434}