arc_bridge: Add more logging, plus cleanup

components/arc/arc_bridge_service_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_bridge_service_impl.h"
 
 #include <string>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
+#include "base/message_loop/message_loop.h"
 #include "base/sequenced_task_runner.h"
 #include "base/sys_info.h"
 #include "base/task_runner_util.h"
 #include "base/thread_task_runner_handle.h"
+#include "base/time/time.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_method_call_status.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 
 namespace arc {
 
 ArcBridgeServiceImpl::ArcBridgeServiceImpl(
     std::unique_ptr<ArcBridgeBootstrap> bootstrap)
     : bootstrap_(std::move(bootstrap)),
       binding_(this),
       session_started_(false),
       weak_factory_(this) {
   bootstrap_->set_delegate(this);
 }
 
-ArcBridgeServiceImpl::~ArcBridgeServiceImpl() {
-}
-
 void ArcBridgeServiceImpl::HandleStartup() {
+  VLOG(1) << "Session started";
   DCHECK(CalledOnValidThread());
   session_started_ = true;
   PrerequisitesChanged();
 }
 
 void ArcBridgeServiceImpl::Shutdown() {
+  VLOG(1) << "Session ended";
   DCHECK(CalledOnValidThread());
   session_started_ = false;
   PrerequisitesChanged();
 }
 
 void ArcBridgeServiceImpl::PrerequisitesChanged() {
   DCHECK(CalledOnValidThread());
   if (state() == State::STOPPED) {
     if (!available() || !session_started_)
       return;
+    VLOG(0) << "Prerequisites met, starting ARC";
     SetState(State::CONNECTING);
     bootstrap_->Start();
   } else {
     if (available() && session_started_)
       return;
+    VLOG(0) << "Prerequisites stopped being met, stopping ARC";
     StopInstance();
   }
 }
 
 void ArcBridgeServiceImpl::StopInstance() {
   DCHECK(CalledOnValidThread());
   if (state() == State::STOPPED || state() == State::STOPPING) {
     VLOG(1) << "StopInstance() called when ARC is not running";
     return;
   }
 
+  VLOG(1) << "Stopping ARC";
   SetState(State::STOPPING);
   instance_ptr_.reset();
   if (binding_.is_bound())
     binding_.Close();
   bootstrap_->Stop();
 }
 
 void ArcBridgeServiceImpl::SetDetectedAvailability(bool arc_available) {
   DCHECK(CalledOnValidThread());
   if (available() == arc_available)
     return;
+  VLOG(1) << "ARC available: " << arc_available;
   SetAvailable(arc_available);
   PrerequisitesChanged();
 }
 
 void ArcBridgeServiceImpl::OnConnectionEstablished(
     mojom::ArcBridgeInstancePtr instance) {
   DCHECK(CalledOnValidThread());
   if (state() != State::CONNECTING) {
     VLOG(1) << "StopInstance() called while connecting";
     return;
   }
 
   instance_ptr_ = std::move(instance);
   instance_ptr_.set_connection_error_handler(base::Bind(
       &ArcBridgeServiceImpl::OnChannelClosed, weak_factory_.GetWeakPtr()));
 
   instance_ptr_->Init(binding_.CreateInterfacePtrAndBind());
 
+  VLOG(0) << "ARC ready";
   SetState(State::READY);
 }
 
 void ArcBridgeServiceImpl::OnStopped() {
   DCHECK(CalledOnValidThread());
   SetState(State::STOPPED);
+  VLOG(0) << "ARC stopped";
   if (reconnect_) {
     // There was a previous invocation and it crashed for some reason. Try
     // starting the container again.
+    VLOG(0) << "ARC reconnecting";
     reconnect_ = false;
-    PrerequisitesChanged();
+    base::MessageLoop::current()->task_runner()->PostDelayedTask(

[Yusuke Sato, 2016/04/29 00:28:41]

What's the purpose of this change? Please mention this in the CL description.

[Luis Héctor Chávez, 2016/04/29 20:23:15]

Done, and added a comment.

+        FROM_HERE, base::Bind(&ArcBridgeServiceImpl::PrerequisitesChanged,
+                              weak_factory_.GetWeakPtr()),
+        base::TimeDelta::FromSeconds(5));

[Yusuke Sato, 2016/04/29 00:28:41]

Can you name the constant?

[Luis Héctor Chávez, 2016/04/29 20:23:15]

Done.

   }
 }
 
 void ArcBridgeServiceImpl::OnChannelClosed() {
   DCHECK(CalledOnValidThread());
   if (state() == State::STOPPED || state() == State::STOPPING) {
     // This will happen when the instance is shut down. Ignore that case.
     return;
   }
   VLOG(1) << "Mojo connection lost";
   CloseAllChannels();
   reconnect_ = true;
   StopInstance();
 }
 
 }  // namespace arc