Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1925083002: Revert of Fix more android logging crashes in run-webkit-tests. (Closed)

Created:
4 years, 7 months ago by mithro
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix more android logging crashes in run-webkit-tests. (patchset #1 id:1 of https://codereview.chromium.org/1930783002/ ) Reason for revert: Reverting to land https://codereview.chromium.org/1924183002 instead. Original issue's description: > Fix more android logging crashes in run-webkit-tests. > > This CL attempts to fix yet more places where run-webkit-tests > can crash when running tests on Android because we get confused > over whether the byte stream coming from the device is unicode > or not. > > R=jbudorick@chromium.org, mgiuca@chromium.org, mithro@chromium.org, robertshield@chromium.org > BUG=598449 TBR=jbudorick@chromium.org,mgiuca@chromium.org,robertshield@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598449 Committed: https://crrev.com/7899096e6f29c7c12a00fc6be817f84d1658e13c Cr-Commit-Position: refs/heads/master@{#390366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 6 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mithro
Created Revert of Fix more android logging crashes in run-webkit-tests.
4 years, 7 months ago (2016-04-28 13:48:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925083002/1
4 years, 7 months ago (2016-04-28 13:48:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 13:49:00 UTC) #3
Dirk Pranke
lgtm.
4 years, 7 months ago (2016-04-28 16:07:52 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:18:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7899096e6f29c7c12a00fc6be817f84d1658e13c
Cr-Commit-Position: refs/heads/master@{#390366}

Powered by Google App Engine
This is Rietveld 408576698