Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1924183002: webkitpy: Replace errors when decoding input. (Closed)

Created:
4 years, 7 months ago by mithro
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Replace errors when decoding input. Fix more android logging crashes in run-webkit-tests. This CL attempts to fix yet more places where run-webkit-tests can crash when running tests on Android because we get confused over whether the byte stream coming from the device is unicode or not. This is an alternative to https://codereview.chromium.org/1930783002/ BUG=598449 R=dpranke Committed: https://crrev.com/ce79d31d0a3ef406733e0b8499740d4cbef31312 Cr-Commit-Position: refs/heads/master@{#390379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mithro
Hi, See dpranke's last comment on his original fix at https://codereview.chromium.org/1930783002/ The plan is to ...
4 years, 7 months ago (2016-04-28 13:46:17 UTC) #2
jbudorick
On 2016/04/28 13:46:17, mithro wrote: > Hi, > > See dpranke's last comment on his ...
4 years, 7 months ago (2016-04-28 13:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924183002/1
4 years, 7 months ago (2016-04-28 13:55:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 15:00:11 UTC) #6
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-28 16:25:33 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:18:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce79d31d0a3ef406733e0b8499740d4cbef31312
Cr-Commit-Position: refs/heads/master@{#390379}

Powered by Google App Engine
This is Rietveld 408576698