Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1925073002: Revert of [turbofan] Run everything after representation selection concurrently. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Run everything after representation selection concurrently. (patchset #2 id:20001 of https://codereview.chromium.org/1926023002/ ) Reason for revert: [Sheriff] Flaky crashed here and there: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9867 https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/9589 https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/7679 Original issue's description: > [turbofan] Run everything after representation selection concurrently. > > Further refactor the pipeline to even run the first scheduler (part of > the effect control linearization) concurrently. This temporarily > disables most of the write barrier elimination, but we will get back to > that later. TBR=mstarzinger@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9212be866d879221829eb78621f46ebd3a0a69d9 Cr-Commit-Position: refs/heads/master@{#35863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -333 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/code-factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/code-stubs.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.h View 1 chunk +24 lines, -10 lines 0 comments Download
M src/compiler/change-lowering.cc View 7 chunks +149 lines, -34 lines 0 comments Download
M src/compiler/common-node-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/instruction.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +23 lines, -18 lines 0 comments Download
M src/handles.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [turbofan] Run everything after representation selection concurrently.
4 years, 7 months ago (2016-04-28 13:13:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925073002/1
4 years, 7 months ago (2016-04-28 13:13:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 13:13:45 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9212be866d879221829eb78621f46ebd3a0a69d9
Cr-Commit-Position: refs/heads/master@{#35863}

Powered by Google App Engine
This is Rietveld 408576698