Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: src/compiler/pipeline.cc

Issue 1925073002: Revert of [turbofan] Run everything after representation selection concurrently. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/handles.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index f89484d08426b5a06f826b0adbec247e79e7ed03..3ea6c2ba812ef824b2ddadd4ee03040b062c3c94 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1302,11 +1302,13 @@
}
// Type the graph.
- Typer typer(isolate(), data->graph(), info()->is_deoptimization_enabled()
- ? Typer::kDeoptimizationEnabled
- : Typer::kNoFlags,
- info()->dependencies());
- Run<TyperPhase>(&typer);
+ base::SmartPointer<Typer> typer;
+ typer.Reset(new Typer(isolate(), data->graph(),
+ info()->is_deoptimization_enabled()
+ ? Typer::kDeoptimizationEnabled
+ : Typer::kNoFlags,
+ info()->dependencies()));
+ Run<TyperPhase>(typer.get());
RunPrintAndVerify("Typed");
BeginPhaseKind("lowering");
@@ -1333,32 +1335,35 @@
Run<EarlyOptimizationPhase>();
RunPrintAndVerify("Early optimized");
- EndPhaseKind();
-
- return true;
-}
-
-bool Pipeline::OptimizeGraph(Linkage* linkage) {
- PipelineData* data = this->data_;
-
- BeginPhaseKind("block building");
-
Run<EffectControlLinearizationPhase>();
- RunPrintAndVerify("Effect and control linearized", true);
+ RunPrintAndVerify("Effect and control linearized");
Run<BranchEliminationPhase>();
- RunPrintAndVerify("Branch conditions eliminated", true);
+ RunPrintAndVerify("Branch conditions eliminated");
// Optimize control flow.
if (FLAG_turbo_cf_optimization) {
Run<ControlFlowOptimizationPhase>();
- RunPrintAndVerify("Control flow optimized", true);
+ RunPrintAndVerify("Control flow optimized");
}
// Lower changes that have been inserted before.
Run<LateOptimizationPhase>();
// TODO(jarin, rossberg): Remove UNTYPED once machine typing works.
RunPrintAndVerify("Late optimized", true);
+
+ // Kill the Typer and thereby uninstall the decorator (if any).
+ typer.Reset(nullptr);
+
+ EndPhaseKind();
+
+ return true;
+}
+
+bool Pipeline::OptimizeGraph(Linkage* linkage) {
+ PipelineData* data = this->data_;
+
+ BeginPhaseKind("block building");
Run<LateGraphTrimmingPhase>();
// TODO(jarin, rossberg): Remove UNTYPED once machine typing works.
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698