cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

This CL removes pushing properties :
clip_parent, chil_children, scroll parent, scroll_children

BUG=602438
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e
Cr-Commit-Position: refs/heads/master@{#390273}

[jaydasika, 2016-04-27 21:27:00]

Description was changed from

==========
cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

This CL removes pushing properties :
clip_parent, chil_children, scroll parent, scroll_children

BUG=602438
==========

to

==========
cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

This CL removes pushing properties :
clip_parent, chil_children, scroll parent, scroll_children

BUG=602438
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-04-27 21:30:01]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-04-27 21:30:01]

PTAL

[ajuma, 2016-04-27 21:57:21]

lgtm, it's great to see more code getting deleted :)

https://codereview.chromium.org/1924933002/diff/1/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/1924933002/diff/1/cc/BUILD.gn#newcode123
cc/BUILD.gn:123: "layers/layer_impl_test_properties.h",
This also needs to go in cc.gyp (there are still platforms that haven't been
converted to gn yet).

https://codereview.chromium.org/1924933002/diff/1/cc/trees/tree_synchronizer.cc
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/1924933002/diff/1/cc/trees/tree_synchronizer....
cc/trees/tree_synchronizer.cc:149: CheckScrollAndClipPointersForLayer(layer);
Since scroll and clip children aren't being pushed anymore, this checking
probably fits better in PropertyTreeBuilder. How about moving it there in a
follow-up?

[jaydasika, 2016-04-27 23:52:00]

Patchset #3 (id:40001) has been deleted

[jaydasika, 2016-04-28 01:50:01]

https://codereview.chromium.org/1924933002/diff/1/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/1924933002/diff/1/cc/BUILD.gn#newcode123
cc/BUILD.gn:123: "layers/layer_impl_test_properties.h",
On 2016/04/27 21:57:21, ajuma wrote:
> This also needs to go in cc.gyp (there are still platforms that haven't been
> converted to gn yet).

Done.

https://codereview.chromium.org/1924933002/diff/1/cc/trees/tree_synchronizer.cc
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/1924933002/diff/1/cc/trees/tree_synchronizer....
cc/trees/tree_synchronizer.cc:149: CheckScrollAndClipPointersForLayer(layer);
On 2016/04/27 21:57:21, ajuma wrote:
> Since scroll and clip children aren't being pushed anymore, this checking
> probably fits better in PropertyTreeBuilder. How about moving it there in a
> follow-up?

Acknowledged.

[jaydasika, 2016-04-28 01:50:05]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-04-28 01:50:06]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1924933002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-28 01:50:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924933002/60001

[commit-bot: I haz the power, 2016-04-28 01:55:11]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-30 17:15:31]

Patchset 3 (id:??) landed as
https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e
Cr-Commit-Position: refs/heads/master@{#390273}

[commit-bot: I haz the power, 2016-04-30 17:53:44]

Description was changed from

==========
cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

This CL removes pushing properties :
clip_parent, chil_children, scroll parent, scroll_children

BUG=602438
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

This CL removes pushing properties :
clip_parent, chil_children, scroll parent, scroll_children

BUG=602438
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e
Cr-Commit-Position: refs/heads/master@{#390273}
==========