Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: cc/trees/tree_synchronizer.cc

Issue 1924933002: cc : Stop pushing properties not used by LayerImpl to LayerImpl (4) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/property_tree_builder.cc ('k') | cc/trees/tree_synchronizer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/tree_synchronizer.cc
diff --git a/cc/trees/tree_synchronizer.cc b/cc/trees/tree_synchronizer.cc
index 1bd19bf5fb5d63795fd2b26de8041302f8611926..d055f4cb3060acc455f3e35734fa91047c8b0339 100644
--- a/cc/trees/tree_synchronizer.cc
+++ b/cc/trees/tree_synchronizer.cc
@@ -125,59 +125,28 @@ void SynchronizeTreesRecursive(OwnedLayerImplMap* old_layers,
}
#if DCHECK_IS_ON()
-static void CheckScrollAndClipPointersForLayer(Layer* layer,
- LayerImpl* layer_impl) {
- DCHECK_EQ(!!layer, !!layer_impl);
+static void CheckScrollAndClipPointersForLayer(Layer* layer) {
if (!layer)
return;
- // Having a scroll parent on the impl thread implies having one the main
- // thread, too. The main thread may have a scroll parent that is not in the
- // tree because it's been removed but not deleted. In this case, the layer
- // impl will have no scroll parent. Same argument applies for clip parents and
- // scroll/clip children.
- DCHECK(!layer_impl->scroll_parent() || !!layer->scroll_parent());
- DCHECK(!layer_impl->clip_parent() || !!layer->clip_parent());
- DCHECK(!layer_impl->scroll_children() || !!layer->scroll_children());
- DCHECK(!layer_impl->clip_children() || !!layer->clip_children());
-
- if (layer_impl->scroll_parent())
- DCHECK_EQ(layer->scroll_parent()->id(), layer_impl->scroll_parent()->id());
-
- if (layer_impl->clip_parent())
- DCHECK_EQ(layer->clip_parent()->id(), layer_impl->clip_parent()->id());
-
- if (layer_impl->scroll_children()) {
+ if (layer->scroll_children()) {
for (std::set<Layer*>::iterator it = layer->scroll_children()->begin();
it != layer->scroll_children()->end(); ++it) {
DCHECK_EQ((*it)->scroll_parent(), layer);
}
- for (std::set<LayerImpl*>::iterator it =
- layer_impl->scroll_children()->begin();
- it != layer_impl->scroll_children()->end(); ++it) {
- DCHECK_EQ((*it)->scroll_parent(), layer_impl);
- }
}
- if (layer_impl->clip_children()) {
+ if (layer->clip_children()) {
for (std::set<Layer*>::iterator it = layer->clip_children()->begin();
it != layer->clip_children()->end(); ++it) {
DCHECK_EQ((*it)->clip_parent(), layer);
}
- for (std::set<LayerImpl*>::iterator it =
- layer_impl->clip_children()->begin();
- it != layer_impl->clip_children()->end(); ++it) {
- DCHECK_EQ((*it)->clip_parent(), layer_impl);
- }
}
}
-static void CheckScrollAndClipPointers(LayerTreeHost* host,
- LayerTreeImpl* host_impl) {
- for (auto* layer_impl : *host_impl) {
- Layer* layer = host->LayerById(layer_impl->id());
- CheckScrollAndClipPointersForLayer(layer, layer_impl);
- }
+static void CheckScrollAndClipPointers(LayerTreeHost* host) {
+ for (auto* layer : *host)
+ CheckScrollAndClipPointersForLayer(layer);
}
#endif
@@ -204,8 +173,8 @@ void TreeSynchronizer::PushLayerProperties(LayerTreeHost* host_tree,
impl_tree);
#if DCHECK_IS_ON()
- if (host_tree->root_layer() && impl_tree->root_layer())
- CheckScrollAndClipPointers(host_tree, impl_tree);
+ if (host_tree->root_layer())
+ CheckScrollAndClipPointers(host_tree);
#endif
}
« no previous file with comments | « cc/trees/property_tree_builder.cc ('k') | cc/trees/tree_synchronizer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698