Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 19248002: Fix unaligned accesses in back_edge tables. (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

Fix unaligned accesses in back_edge tables. This patch fixes the step size of masm->pc_ in back_edge tables to words (4 bytes) to ensure 4 bytes alignment for read/write operations. Read and write of words (4 bytes) data from aligned space (address % 4 == 0) is more efficient on all platforms and especially on MIPS where without this alignment fix a kernel exception handler is used for every unaligned access. This patch increases the size of back_edge tables by 3 bytes in every row. By the test it seem the back_edge table quite small in every/most cases (maximal length is 18 so in that case there are only 54 additional bytes with this patch). BUG= Patch from Douglas Leung <Douglas.Leung@imgtec.com>;

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased; nit fix #

Patch Set 3 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/deoptimizer.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kisg
https://codereview.chromium.org/19248002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/19248002/diff/1/src/deoptimizer.cc#newcode2434 src/deoptimizer.cc:2434: int32_t loop_depth = Memory::int32_at(back_edge_cursor + 2 * kIntSize); Instead ...
7 years, 5 months ago (2013-07-18 15:46:52 UTC) #1
kisg
LGTM
7 years, 5 months ago (2013-07-18 18:12:03 UTC) #2
kilvadyb
https://codereview.chromium.org/19248002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/19248002/diff/1/src/deoptimizer.cc#newcode2434 src/deoptimizer.cc:2434: int32_t loop_depth = Memory::int32_at(back_edge_cursor + 2 * kIntSize); On ...
7 years, 5 months ago (2013-07-18 18:22:43 UTC) #3
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-19 12:58:44 UTC) #4
palfia
7 years, 5 months ago (2013-07-19 14:47:19 UTC) #5
Committed as r15782.

Powered by Google App Engine
This is Rietveld 408576698