Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/full-codegen.cc

Issue 19248002: Fix unaligned accesses in back_edge tables. (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Fixed nit. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen.h ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 // The back edge table consists of a length (in number of entries) 372 // The back edge table consists of a length (in number of entries)
373 // field, and then a sequence of entries. Each entry is a pair of AST id 373 // field, and then a sequence of entries. Each entry is a pair of AST id
374 // and code-relative pc offset. 374 // and code-relative pc offset.
375 masm()->Align(kIntSize); 375 masm()->Align(kIntSize);
376 unsigned offset = masm()->pc_offset(); 376 unsigned offset = masm()->pc_offset();
377 unsigned length = back_edges_.length(); 377 unsigned length = back_edges_.length();
378 __ dd(length); 378 __ dd(length);
379 for (unsigned i = 0; i < length; ++i) { 379 for (unsigned i = 0; i < length; ++i) {
380 __ dd(back_edges_[i].id.ToInt()); 380 __ dd(back_edges_[i].id.ToInt());
381 __ dd(back_edges_[i].pc); 381 __ dd(back_edges_[i].pc);
382 __ db(back_edges_[i].loop_depth); 382 __ dd(back_edges_[i].loop_depth);
383 } 383 }
384 return offset; 384 return offset;
385 } 385 }
386 386
387 387
388 void FullCodeGenerator::PopulateDeoptimizationData(Handle<Code> code) { 388 void FullCodeGenerator::PopulateDeoptimizationData(Handle<Code> code) {
389 // Fill in the deoptimization information. 389 // Fill in the deoptimization information.
390 ASSERT(info_->HasDeoptimizationSupport() || bailout_entries_.is_empty()); 390 ASSERT(info_->HasDeoptimizationSupport() || bailout_entries_.is_empty());
391 if (!info_->HasDeoptimizationSupport()) return; 391 if (!info_->HasDeoptimizationSupport()) return;
392 int length = bailout_entries_.length(); 392 int length = bailout_entries_.length();
(...skipping 1223 matching lines...) Expand 10 before | Expand all | Expand 10 after
1616 } 1616 }
1617 1617
1618 return false; 1618 return false;
1619 } 1619 }
1620 1620
1621 1621
1622 #undef __ 1622 #undef __
1623 1623
1624 1624
1625 } } // namespace v8::internal 1625 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/full-codegen.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698