components/history/core/browser/history_backend_client.h - Issue 1924773002: TopSites: filter out non-WebSafe URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend_client.h

Issue 1924773002: TopSites: filter out non-WebSafe URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@topsites_cleanup

Patch Set: review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend_client.h

diff --git a/components/history/core/browser/history_backend_client.h b/components/history/core/browser/history_backend_client.h

index 8327bd26f7371ea825df03ed36936cd85be13d55..fca8e04a366ed0f46a19a857d87b353dcb0990c1 100644

--- a/components/history/core/browser/history_backend_client.h

+++ b/components/history/core/browser/history_backend_client.h

@@ -44,6 +44,8 @@ class HistoryBackendClient {

// Returns whether database errors should be reported to the crash server.

virtual bool ShouldReportDatabaseError() = 0;

+ virtual bool IsWebSafe(const GURL& url) = 0;

sdefresne 2016/05/03 12:03:40 Please document this method.

Marc Treib 2016/05/03 12:15:10 Done.

#if defined(OS_ANDROID)

// Called upon initialization of the HistoryBackend.

virtual void OnHistoryBackendInitialized(