Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: components/history/core/browser/history_backend_client.h

Issue 1924773002: TopSites: filter out non-WebSafe URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@topsites_cleanup
Patch Set: review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_CLIENT_H_ 5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_CLIENT_H_
6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_CLIENT_H_ 6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_CLIENT_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 26 matching lines...) Expand all
37 37
38 // Returns, by reference in |bookmarks|, the set of bookmarked URLs and their 38 // Returns, by reference in |bookmarks|, the set of bookmarked URLs and their
39 // title. This returns the unique set of URLs. For example, if two bookmarks 39 // title. This returns the unique set of URLs. For example, if two bookmarks
40 // reference the same URL only one entry is added even if the title are not 40 // reference the same URL only one entry is added even if the title are not
41 // the same. 41 // the same.
42 virtual void GetBookmarks(std::vector<URLAndTitle>* bookmarks) = 0; 42 virtual void GetBookmarks(std::vector<URLAndTitle>* bookmarks) = 0;
43 43
44 // Returns whether database errors should be reported to the crash server. 44 // Returns whether database errors should be reported to the crash server.
45 virtual bool ShouldReportDatabaseError() = 0; 45 virtual bool ShouldReportDatabaseError() = 0;
46 46
47 virtual bool IsWebSafe(const GURL& url) = 0;
sdefresne 2016/05/03 12:03:40 Please document this method.
Marc Treib 2016/05/03 12:15:10 Done.
48
47 #if defined(OS_ANDROID) 49 #if defined(OS_ANDROID)
48 // Called upon initialization of the HistoryBackend. 50 // Called upon initialization of the HistoryBackend.
49 virtual void OnHistoryBackendInitialized( 51 virtual void OnHistoryBackendInitialized(
50 HistoryBackend* history_backend, 52 HistoryBackend* history_backend,
51 HistoryDatabase* history_database, 53 HistoryDatabase* history_database,
52 ThumbnailDatabase* thumbnail_database, 54 ThumbnailDatabase* thumbnail_database,
53 const base::FilePath& history_dir) = 0; 55 const base::FilePath& history_dir) = 0;
54 56
55 // Called upon destruction of the HistoryBackend. 57 // Called upon destruction of the HistoryBackend.
56 virtual void OnHistoryBackendDestroyed(HistoryBackend* history_backend, 58 virtual void OnHistoryBackendDestroyed(HistoryBackend* history_backend,
57 const base::FilePath& history_dir) = 0; 59 const base::FilePath& history_dir) = 0;
58 #endif // defined(OS_ANDROID) 60 #endif // defined(OS_ANDROID)
59 61
60 private: 62 private:
61 DISALLOW_COPY_AND_ASSIGN(HistoryBackendClient); 63 DISALLOW_COPY_AND_ASSIGN(HistoryBackendClient);
62 }; 64 };
63 65
64 } // namespace history 66 } // namespace history
65 67
66 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_CLIENT_H_ 68 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_CLIENT_H_
OLDNEW
« no previous file with comments | « components/history/core/browser/history_backend.cc ('k') | components/history/core/browser/history_backend_db_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698