Source/core/css/CSSImportRule.cpp - Issue 192473003: Move CSSRuleList to the garbage collected heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSImportRule.cpp

Issue 192473003: Move CSSRuleList to the garbage collected heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove persistent from m_authorStyleSheets in StyleEngine.h Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSImportRule.cpp

diff --git a/Source/core/css/CSSImportRule.cpp b/Source/core/css/CSSImportRule.cpp

index a552f7b9560a87ea6a8dc330c7c0c5684ffae14b..b05998b3f622001cd4bfb48099a4434123eb8901 100644

--- a/Source/core/css/CSSImportRule.cpp

+++ b/Source/core/css/CSSImportRule.cpp

@@ -38,8 +38,6 @@ CSSImportRule::CSSImportRule(StyleRuleImport* importRule, CSSStyleSheet* parent)

CSSImportRule::~CSSImportRule()

{

- if (m_styleSheetCSSOMWrapper)

Mads Ager (chromium) 2014/03/10 12:32:56 Uh, careful. We probably still need this when !ENA

Erik Corry 2014/03/12 12:31:27 Done.

- m_styleSheetCSSOMWrapper->clearOwnerRule();

#if !ENABLE(OILPAN)

// MediaList and the parent CSSImportRule are both on the oilpan heap and die together.

// Therefor clearing is not needed nor allowed since it could be touching already