Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: Source/core/css/CSSImportRule.cpp

Issue 192473003: Move CSSRuleList to the garbage collected heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove persistent from m_authorStyleSheets in StyleEngine.h Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org) 3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2002, 2005, 2006, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2002, 2005, 2006, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 20 matching lines...) Expand all
31 namespace WebCore { 31 namespace WebCore {
32 32
33 CSSImportRule::CSSImportRule(StyleRuleImport* importRule, CSSStyleSheet* parent) 33 CSSImportRule::CSSImportRule(StyleRuleImport* importRule, CSSStyleSheet* parent)
34 : CSSRule(parent) 34 : CSSRule(parent)
35 , m_importRule(importRule) 35 , m_importRule(importRule)
36 { 36 {
37 } 37 }
38 38
39 CSSImportRule::~CSSImportRule() 39 CSSImportRule::~CSSImportRule()
40 { 40 {
41 if (m_styleSheetCSSOMWrapper)
Mads Ager (chromium) 2014/03/10 12:32:56 Uh, careful. We probably still need this when !ENA
Erik Corry 2014/03/12 12:31:27 Done.
42 m_styleSheetCSSOMWrapper->clearOwnerRule();
43 #if !ENABLE(OILPAN) 41 #if !ENABLE(OILPAN)
44 // MediaList and the parent CSSImportRule are both on the oilpan heap and di e together. 42 // MediaList and the parent CSSImportRule are both on the oilpan heap and di e together.
45 // Therefor clearing is not needed nor allowed since it could be touching al ready 43 // Therefor clearing is not needed nor allowed since it could be touching al ready
46 // finalized memory. 44 // finalized memory.
47 if (m_mediaCSSOMWrapper) 45 if (m_mediaCSSOMWrapper)
48 m_mediaCSSOMWrapper->clearParentRule(); 46 m_mediaCSSOMWrapper->clearParentRule();
49 #endif // ENABLE(OILPAN) 47 #endif // ENABLE(OILPAN)
50 } 48 }
51 49
52 String CSSImportRule::href() const 50 String CSSImportRule::href() const
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 } 95 }
98 96
99 void CSSImportRule::trace(Visitor* visitor) 97 void CSSImportRule::trace(Visitor* visitor)
100 { 98 {
101 visitor->trace(m_importRule); 99 visitor->trace(m_importRule);
102 visitor->trace(m_mediaCSSOMWrapper); 100 visitor->trace(m_mediaCSSOMWrapper);
103 CSSRule::trace(visitor); 101 CSSRule::trace(visitor);
104 } 102 }
105 103
106 } // namespace WebCore 104 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698