Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1924693005: Update cr_cronet.py to allow arbitrary build directories (Closed)

Created:
4 years, 7 months ago by mgersh
Modified:
4 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update cr_cronet.py to allow arbitrary build directories Now that we're building with GN, we aren't restricted to out/Debug and out/Release. Some cronet developers might want to name their directories differently. BUG=600857 Committed: https://crrev.com/62d2e21291d90966c984748532a0f254dab2322b Cr-Commit-Position: refs/heads/master@{#390524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M components/cronet/tools/cr_cronet.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mgersh
PTAL
4 years, 7 months ago (2016-04-28 17:57:01 UTC) #2
mef
lgtm
4 years, 7 months ago (2016-04-28 21:37:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924693005/1
4 years, 7 months ago (2016-04-28 21:39:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 22:54:16 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62d2e21291d90966c984748532a0f254dab2322b
Cr-Commit-Position: refs/heads/master@{#390524}

Powered by Google App Engine
This is Rietveld 408576698