Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 1924693005: Update cr_cronet.py to allow arbitrary build directories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/cr_cronet.py
diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py
index 690851ee833e2ee200a98ae25ea8b6c10b4337c2..c852077666cf9bd2b56935a74bf1708c49871161 100755
--- a/components/cronet/tools/cr_cronet.py
+++ b/components/cronet/tools/cr_cronet.py
@@ -62,6 +62,8 @@ def main():
'stack',
'debug',
'build-debug'])
+ parser.add_argument('-d', '--out_dir', action='store',
+ help='name of the build directory')
parser.add_argument('-i', '--iphoneos', action='store_true',
help='build for physical iphone')
parser.add_argument('-r', '--release', action='store_true',
@@ -92,13 +94,17 @@ def main():
'use_errorprone_java_compiler=true use_platform_icu_alternatives=true '+ \
'disable_brotli_filter=true'
- out_dir = 'out/Debug' + out_dir_suffix
- release_arg = ''
extra_options = ' '.join(extra_options_list)
if options.release:
out_dir = 'out/Release' + out_dir_suffix
release_arg = ' --release'
gn_args += ' is_debug=false '
+ else:
+ out_dir = 'out/Debug' + out_dir_suffix
+ release_arg = ''
+
+ if options.out_dir:
+ out_dir = options.out_dir
if (options.command=='gyp'):
return run (gyp_defines + ' gclient runhooks')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698