Issue 1924683002: Code completion bug fix, https://github.com/dart-lang/sdk/issues/26342, and test cleanup in variabl…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1924683002: Code completion bug fix, https://github.com/dart-lang/sdk/issues/26342, and test cleanup in variabl… (Closed)

Created:
4 years, 8 months ago by jwren

Modified:
4 years, 7 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Code completion bug fix, https://github.com/dart-lang/sdk/issues/26342, and test cleanup in variable_name_contributor_test.dart BUG=https://github.com/dart-lang/sdk/issues/26342 R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/1aee4602bc5cd064cd861f735d744f079cac8bc0

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -25 lines)			Patch
	M	pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	pkg/analysis_server/test/services/completion/dart/variable_name_contributor_test.dart	View		8 chunks	+72 lines, -25 lines	0 comments	Download

Total messages: 5 (2 generated)

jwren

4 years, 7 months ago (2016-04-27 16:26:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1aee4602bc5cd064cd861f735d744f079cac8bc0 (presubmit successful).