pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart - Issue 1924683002: Code completion bug fix, https://github.com/dart-lang/sdk/issues/26342, and test cleanup in variabl…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart

Issue 1924683002: Code completion bug fix, https://github.com/dart-lang/sdk/issues/26342, and test cleanup in variabl… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebase with bleeding_edge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart

index 71ac473ffc0dd12cb6b703d93d75189a5fa9a1c5..2c4d91352a1c618a5b62eae33685a24d75f5d3aa 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart

@@ -80,6 +80,7 @@ class VariableNameContributor extends DartCompletionContributor {

}

List<String> variableNameSuggestions = getCamelWordCombinations(strName);

+ variableNameSuggestions.remove(strName);

List<CompletionSuggestion> suggestions = <CompletionSuggestion>[];

for (String varName in variableNameSuggestions) {

CompletionSuggestion suggestion = _createNameSuggestion(varName);

« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/dart/variable_name_contributor_test.dart » ('j') | no next file with comments »