Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1924643004: X87: Get rid of AllocationFlags::TAG_OBJECT. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Get rid of AllocationFlags::TAG_OBJECT. port ef49c6b11a7a382909c2fbe1c5f38a8c3e1e4fb8 (r35792) original commit message: Default (and only way) is now to retrieve a tagged object. BUG= Committed: https://crrev.com/52e946ea906de9bb2816217f0d0fd4285859912b Cr-Commit-Position: refs/heads/master@{#35808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/x87/codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-04-27 02:16:42 UTC) #2
Michael Lippautz
lgtm
4 years, 7 months ago (2016-04-27 07:08:49 UTC) #3
Weiliang
lgtm
4 years, 7 months ago (2016-04-27 07:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924643004/1
4 years, 7 months ago (2016-04-27 07:10:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 07:30:30 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 07:31:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52e946ea906de9bb2816217f0d0fd4285859912b
Cr-Commit-Position: refs/heads/master@{#35808}

Powered by Google App Engine
This is Rietveld 408576698