Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: src/x87/macro-assembler-x87.cc

Issue 1924643004: X87: Get rid of AllocationFlags::TAG_OBJECT. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x87/codegen-x87.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x87/macro-assembler-x87.cc
diff --git a/src/x87/macro-assembler-x87.cc b/src/x87/macro-assembler-x87.cc
index 840913797c72897fd442d0225e9dce7581ff1f16..068cc5f01e2f74bc07171f5d5f80258a07b3f2c8 100644
--- a/src/x87/macro-assembler-x87.cc
+++ b/src/x87/macro-assembler-x87.cc
@@ -1520,10 +1520,10 @@ void MacroAssembler::Allocate(int object_size,
// Update allocation top.
UpdateAllocationTopHelper(top_reg, scratch, flags);
- // Tag result if requested.
if (top_reg.is(result)) {
sub(result, Immediate(object_size - kHeapObjectTag));
} else {
+ // Tag the result.
DCHECK(kHeapObjectTag == 1);
inc(result);
}
@@ -1597,6 +1597,7 @@ void MacroAssembler::Allocate(int header_size,
cmp(result_end, Operand::StaticVariable(allocation_limit));
j(above, gc_required);
+ // Tag result.
DCHECK(kHeapObjectTag == 1);
inc(result);
« no previous file with comments | « src/x87/codegen-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698