Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6b98cf9e84a04eb430243dd60ae0d246d1cdc55f
Cr-Commit-Position: refs/heads/master@{#390309}

[Fady Samuel, 2016-04-26 20:24:29]

Description was changed from

==========
wip: Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=
==========

to

==========
wip: Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-04-26 20:24:48]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 20:25:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/1

[commit-bot: I haz the power, 2016-04-26 20:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:29:46]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Fady Samuel, 2016-04-26 21:23:26]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 21:23:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/20001

[commit-bot: I haz the power, 2016-04-26 21:29:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:29:18]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-04-26 22:04:14]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 22:05:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/40001

[commit-bot: I haz the power, 2016-04-26 22:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 22:10:13]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fady Samuel, 2016-04-26 22:19:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 22:19:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/60001

[Fady Samuel, 2016-04-26 22:29:10]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 22:29:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/80001

[commit-bot: I haz the power, 2016-04-26 22:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 22:42:00]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Fady Samuel, 2016-04-26 23:02:31]

Description was changed from

==========
wip: Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=586390
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-04-26 23:04:31]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org, sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2016-04-26 23:04:33]

+sky@ for ui/ OWNER
+piman@ for content/, and gpu/ OWNER
+tsepez@ for ipc review (nothing changing, just moving files).

[Fady Samuel, 2016-04-26 23:04:42]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 23:05:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/100001

[Tom Sepez, 2016-04-26 23:12:17]

lgtm

[commit-bot: I haz the power, 2016-04-26 23:14:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 23:14:28]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-04-26 23:38:23]

lgtm

[Fady Samuel, 2016-04-26 23:40:25]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 23:40:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/120001

[commit-bot: I haz the power, 2016-04-27 00:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 00:02:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-04-27 00:05:42]

LGTM

https://codereview.chromium.org/1924613002/diff/120001/ui/gfx/ipc/geometry/gf...
File ui/gfx/ipc/geometry/gfx_ipc_geometry_export.h (right):

https://codereview.chromium.org/1924613002/diff/120001/ui/gfx/ipc/geometry/gf...
ui/gfx/ipc/geometry/gfx_ipc_geometry_export.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
nit: 2016

[Fady Samuel, 2016-04-27 00:44:58]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 00:45:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/140001

[commit-bot: I haz the power, 2016-04-27 01:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 01:10:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Fady Samuel, 2016-04-27 01:31:43]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-27 01:31:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1924613002/#ps130040
(title: "Removed unnecessary code + addressed nit")

[Fady Samuel, 2016-04-27 01:32:00]

CQ'ing

https://codereview.chromium.org/1924613002/diff/120001/ui/gfx/ipc/geometry/gf...
File ui/gfx/ipc/geometry/gfx_ipc_geometry_export.h (right):

https://codereview.chromium.org/1924613002/diff/120001/ui/gfx/ipc/geometry/gf...
ui/gfx/ipc/geometry/gfx_ipc_geometry_export.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2016/04/27 00:05:42, sky wrote:
> nit: 2016

Done.

[commit-bot: I haz the power, 2016-04-27 01:32:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/130040
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/130040

[commit-bot: I haz the power, 2016-04-27 01:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 01:36:57]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-04-27 20:24:00]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 20:24:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/170001

[commit-bot: I haz the power, 2016-04-27 20:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 20:39:31]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Fady Samuel, 2016-04-27 23:02:06]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-27 23:02:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1924613002/#ps190001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-27 23:02:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/190001

[commit-bot: I haz the power, 2016-04-27 23:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 23:13:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-28 00:14:17]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-04-28 00:14:48]

Description was changed from

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=586390
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-28 00:14:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/210001

[commit-bot: I haz the power, 2016-04-28 00:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 00:30:10]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Fady Samuel, 2016-04-28 01:41:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 01:41:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/230001

[commit-bot: I haz the power, 2016-04-28 02:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 02:18:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Fady Samuel, 2016-04-28 02:46:55]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 02:47:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/250001

[commit-bot: I haz the power, 2016-04-28 02:50:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 02:50:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-04-28 03:02:51]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 03:03:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/270001

[commit-bot: I haz the power, 2016-04-28 03:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 03:39:09]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Ryan Sleevi, 2016-04-28 04:14:01]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-04-28 04:14:03]

https://codereview.chromium.org/1924613002/diff/270001/ui/gfx/ipc/gfx_param_t...
File ui/gfx/ipc/gfx_param_traits.h (right):

https://codereview.chromium.org/1924613002/diff/270001/ui/gfx/ipc/gfx_param_t...
ui/gfx/ipc/gfx_param_traits.h:15: #include "ui/gfx/range/range.h"
I believe this is what is causing your error (range.h pulls in windows.h at
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/range/range...
). Anything that deals with this IPC message is now pulling in windows.h, and
the extension / socket code (through the power of transitive headers) is doing
that, so ... yeah.

Given that windows.h squats on the word "interface", you should just fix up that
extensions code to avoid the risk.

[Fady Samuel, 2016-04-28 04:24:58]

Description was changed from

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC should not
need to pull in other parts of ui/gfx (in particular skia-dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-04-28 04:25:36]

Description was changed from

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC should not
need to pull in other parts of ui/gfx (in particular skia-dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC 
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-04-28 04:28:11]

Thanks Ryan. I've forward declared in gfx_param_traits. I'll rename interface in
a separate CL. CQ'ing now.

https://codereview.chromium.org/1924613002/diff/270001/ui/gfx/ipc/gfx_param_t...
File ui/gfx/ipc/gfx_param_traits.h (right):

https://codereview.chromium.org/1924613002/diff/270001/ui/gfx/ipc/gfx_param_t...
ui/gfx/ipc/gfx_param_traits.h:15: #include "ui/gfx/range/range.h"
On 2016/04/28 04:14:03, Ryan Sleevi wrote:
> I believe this is what is causing your error (range.h pulls in windows.h at
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/range/range...
> ). Anything that deals with this IPC message is now pulling in windows.h, and
> the extension / socket code (through the power of transitive headers) is doing
> that, so ... yeah.
> 
> Given that windows.h squats on the word "interface", you should just fix up
that
> extensions code to avoid the risk.

Wow, thanks for catching that! Now I know what to look for in the future :-)
Thanks again!

[Fady Samuel, 2016-04-28 04:28:28]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-28 04:28:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1924613002/#ps290001
(title: "Forward declare Range in gfx_param_traits")

[commit-bot: I haz the power, 2016-04-28 04:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924613002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924613002/290001

[commit-bot: I haz the power, 2016-04-28 05:42:40]

Description was changed from

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC 
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC 
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-28 05:42:42]

Committed patchset #16 (id:290001)

[commit-bot: I haz the power, 2016-04-30 17:16:27]

Patchset 16 (id:??) landed as
https://crrev.com/6b98cf9e84a04eb430243dd60ae0d246d1cdc55f
Cr-Commit-Position: refs/heads/master@{#390309}

[commit-bot: I haz the power, 2016-04-30 17:54:22]

Description was changed from

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC 
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move ui/gfx/geometry ParamTraits to ui/gfx/ipc/geometry

Targets that depend on serializing ui/gfx/geometry types over IPC
should not need to pull in other parts of ui/gfx (in particular skia-
dependent parts).

BUG=586390
TBR=jam@chromium.org for various build files in components/ and extensions/ and
media/
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6b98cf9e84a04eb430243dd60ae0d246d1cdc55f
Cr-Commit-Position: refs/heads/master@{#390309}
==========