Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/debugger.cc

Issue 192443004: Complete the switch to ServiceObject (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/platform/json.cc ('K') | « runtime/vm/coverage.cc ('k') | runtime/vm/json_stream.cc » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 00ea8f8211b62097423e95146c4e531a864dd98a..aeffb06021fa882320c6140467ba9b23eeb1730f 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -712,7 +712,9 @@ const char* ActivationFrame::ToCString() {
void ActivationFrame::PrintToJSONObject(JSONObject* jsobj) {
intptr_t line = LineNumber();
const Script& script = Script::Handle(SourceScript());
-
+ // TODO(johnmccutchan): Can we return a reference to a specific frame?
+ jsobj->AddProperty("id", "stacktrace");
+ jsobj->AddProperty("type", "StackFrame");
turnidge 2014/03/10 21:03:28 Why are you adding an id/type to the frame?
jsobj->AddProperty("script", script);
jsobj->AddProperty("line", line);
jsobj->AddProperty("col", ColumnNumber());
« runtime/platform/json.cc ('K') | « runtime/vm/coverage.cc ('k') | runtime/vm/json_stream.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698