Complete the switch to ServiceObject

runtime/vm/debugger.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/debugger.h"
 
 #include "include/dart_api.h"
 
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
@@ skipping 694 matching lines @@
   len++;  // String terminator.
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, func_name, url.ToCString(), line);
   return chars;
 }
 
 
 void ActivationFrame::PrintToJSONObject(JSONObject* jsobj) {
   intptr_t line = LineNumber();
   const Script& script = Script::Handle(SourceScript());
-
+  // TODO(johnmccutchan): Can we return a reference to a specific frame?
+  jsobj->AddProperty("id", "stacktrace");
+  jsobj->AddProperty("type", "StackFrame");

[turnidge, 2014/03/10 21:03:28]

Why are you adding an id/type to the frame?

   jsobj->AddProperty("script", script);
   jsobj->AddProperty("line", line);
   jsobj->AddProperty("col", ColumnNumber());
   jsobj->AddProperty("function", function());
   jsobj->AddProperty("code", code());
 
   // TODO(turnidge): Consider dropping lineString from the frame.
   String& line_string = String::Handle(script.GetLine(line));
   jsobj->AddProperty("lineString", line_string.ToCString());
   {
@@ skipping 1595 matching lines @@
 }
 
 
 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
   ASSERT(bpt->next() == NULL);
   bpt->set_next(code_breakpoints_);
   code_breakpoints_ = bpt;
 }
 
 }  // namespace dart