Chromium Code Reviews Chromium Code Reviews
Issue 192443004:
Complete the switch to ServiceObject (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| Index: runtime/bin/vmservice/client/lib/src/elements/nav_bar.html |
| diff --git a/runtime/bin/vmservice/client/lib/src/elements/nav_bar.html b/runtime/bin/vmservice/client/lib/src/elements/nav_bar.html |
| index 4d8a3621fd7a235bff512b97272f431a059014a6..0dd9e52740525ca91bddabf05ca6b4832d22ff55 100644 |
| --- a/runtime/bin/vmservice/client/lib/src/elements/nav_bar.html |
| +++ b/runtime/bin/vmservice/client/lib/src/elements/nav_bar.html |
| @@ -1,6 +1,5 @@ |
| <head> |
| <link rel="import" href="observatory_element.html"> |
| - <link rel="import" href="isolate_element.html"> |
| </head> |
| <polymer-element name="nav-bar" extends="observatory-element"> |
| @@ -120,6 +119,56 @@ |
| </template> |
| </polymer-element> |
| +<polymer-element name="nav-menu-item-checkbox" extends="observatory-element"> |
| + <template> |
| + <style> |
| + li { |
| + float: none; |
| + border-top: 1px solid #677; |
| + border-bottom: 1px solid #556; position: relative; |
| + } |
| + li:hover { |
| + background: #455; |
| + } |
| + li ul { |
| + display: none; |
| + position: absolute; |
| + top:0; |
| + left: 100%; |
| + list-style: none; |
| + padding: 0; |
| + margin-left: 0; |
| + width: auto; |
| + z-index: 10; |
| + font: 400 16px 'Montserrat', sans-serif; |
| + color: white; |
| + background: #567; |
| + } |
| + li ul:after { |
| + content: ""; clear: both; display: block; |
| + } |
| + li:hover > ul { |
| + display: block; |
| + } |
| + li a { |
| + display: block; |
| + padding: 12px 12px; |
| + color: white; |
| + text-decoration: none; |
| + } |
| + input[type="checkbox"] + label span { |
| + display:inline-block; |
| + width:19px; |
| + height:19px; |
|
turnidge
2014/03/10 21:03:28
I have some questions about this css -- don't see
Cutch
2014/03/11 03:17:48
Done.
|
| + } |
| + </style> |
| + <li> |
| + <input type="checkbox" value="{{ checked }}" checked="{{ checked }}"> |
| + <label><content></content></label> |
| + </li> |
| + </template> |
| +</polymer-element> |
|
turnidge
2014/03/10 21:03:28
Where do you use this custom element? It looks li
Cutch
2014/03/11 03:17:48
Dead code. Removed.
|
| + |
| <polymer-element name="nav-refresh" extends="observatory-element"> |
| <template> |
| <style> |
| @@ -141,10 +190,10 @@ |
| </style> |
| <li> |
| <template if="{{ active }}"> |
| - <button class="active" on-click="{{ buttonClick }}">Refresh</button> |
| + <button class="active" on-click="{{ buttonClick }}">{{ label }}</button> |
| </template> |
| <template if="{{ !active }}"> |
| - <button class="idle" on-click="{{ buttonClick }}">Refresh</button> |
| + <button class="idle" on-click="{{ buttonClick }}">{{ label }}</button> |
| </template> |
| </li> |
| </template> |
| @@ -158,35 +207,35 @@ |
| </template> |
| </polymer-element> |
| -<polymer-element name="isolate-nav-menu" extends="isolate-element"> |
| +<polymer-element name="isolate-nav-menu" extends="observatory-element"> |
| <template> |
| <nav-menu link="#" anchor="{{ isolate.name }}" last="{{ last }}"> |
| - <nav-menu-item link="{{ isolate.hashLink('stacktrace') }}" |
| + <nav-menu-item link="{{ isolate.relativeHashLink('stacktrace') }}" |
| anchor="stack trace"></nav-menu-item> |
| - <nav-menu-item link="{{ isolate.hashLink('profile') }}" |
| + <nav-menu-item link="{{ isolate.relativeHashLink('profile') }}" |
| anchor="cpu profile"></nav-menu-item> |
| - <nav-menu-item link="{{ isolate.hashLink('allocationprofile') }}" |
| + <nav-menu-item link="{{ isolate.relativeHashLink('allocationprofile') }}" |
| anchor="heap profile"></nav-menu-item> |
| - <nav-menu-item link="{{ isolate.hashLink('debug/breakpoints') }}" |
| + <nav-menu-item link="{{ isolate.relativeHashLink('debug/breakpoints') }}" |
| anchor="breakpoints"></nav-menu-item> |
| <content></content> |
| </nav-menu> |
| </template> |
| </polymer-element> |
| -<polymer-element name="library-nav-menu" extends="isolate-element"> |
| +<polymer-element name="library-nav-menu" extends="observatory-element"> |
| <template> |
| - <nav-menu link="{{ isolate.hashLink(library['id']) }}" |
| - anchor="{{ library['name'] }}" last="{{ last }}"> |
| + <nav-menu link="{{ library.hashLink }}" |
| + anchor="{{ library.name }}" last="{{ last }}"> |
| <content></content> |
| </nav-menu> |
| </template> |
| </polymer-element> |
| -<polymer-element name="class-nav-menu" extends="isolate-element"> |
| +<polymer-element name="class-nav-menu" extends="observatory-element"> |
| <template> |
| - <nav-menu link="{{ isolate.hashLink(cls['id']) }}" |
| - anchor="{{ cls['user_name'] }}" last="{{ last }}"> |
| + <nav-menu link="{{ cls.hashLink }}" |
| + anchor="{{ cls.name }}" last="{{ last }}"> |
| <content></content> |
| </nav-menu> |
| </template> |
