Complete the switch to ServiceObject

runtime/bin/vmservice/client/lib/src/elements/script_ref.dart

Index: runtime/bin/vmservice/client/lib/src/elements/script_ref.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/script_ref.dart b/runtime/bin/vmservice/client/lib/src/elements/script_ref.dart
index 4f2794be9e93a720d72f085a2743d5223afc7d7f..1eaf1b46c338e96d11171663404126fcd568fd2b 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/script_ref.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/script_ref.dart
@@ -11,36 +11,25 @@ import 'service_ref.dart';
 class ScriptRefElement extends ServiceRefElement {
   @published int line = -1;
 
-  String get objectId {
-    if (line < 0) {
-      return super.objectId;
-    }
-    // TODO(johnmccutchan): Add a ?line=XX invalidates the idea that this
-    // method returns an objectId.
-    return '${super.objectId}?line=$line';
-  }
-
   String get hoverText {
     if (ref == null) {
-      return '';
+      return super.hoverText;
     }
     if (line < 0) {
-      return ref['user_name'];
+      return ref.vmName;
     } else {
-      return "${ref['user_name']}:$line";
+      return '${ref.vmName}:$line';
     }
   }
 
   String get name {

[turnidge, 2014/03/10 21:03:28]

I'm beginning to wonder if it makes sense to have this shared "name" function. 
Once each model defines a decent set of fields, it probably will make sense to
grab what we want directly from the model instead of building naming smarts into
the <script-ref> element.  I think this was more useful before we broke out the
various subtypes of service ref.

Thinking out loud.

[Cutch, 2014/03/11 03:17:48]

Agreed. Let's discuss how we can make generating display, hover text, and url
uniform.

     if (ref == null) {
-      return '';
+      return super.name;
     }
-    var scriptUrl = ref['user_name'];
-    var shortScriptUrl = scriptUrl.substring(scriptUrl.lastIndexOf('/') + 1);
     if (line < 0) {
-      return shortScriptUrl;
+      return ref.name;
     } else {
-      return "$shortScriptUrl:$line";
+      return '${ref.name}:$line';
     }
   }