Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1924333003: Move V8 GC trace events to their own catergory. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move V8 GC trace events to their own catergory. This will allow us to enable GC events without enabling IC events. Telemetry currently cannot handle huge number of IC events in a trace. BUG= Committed: https://crrev.com/25fbb9047e46e792db7dd91c2effeed5ce3dc5a7 Cr-Commit-Position: refs/heads/master@{#35902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/gc-tracer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
ulan
ptal
4 years, 7 months ago (2016-04-29 09:18:49 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 7 months ago (2016-04-29 11:16:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924333003/1
4 years, 7 months ago (2016-04-29 11:16:49 UTC) #7
Michael Lippautz
lgtm
4 years, 7 months ago (2016-04-29 11:33:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 11:42:46 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25fbb9047e46e792db7dd91c2effeed5ce3dc5a7
Cr-Commit-Position: refs/heads/master@{#35902}

Powered by Google App Engine
This is Rietveld 408576698