Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 192433003: Avoid black flashes when resizing debugger window using MSAA (Closed)

Created:
6 years, 9 months ago by Kimmo Kinnunen
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Avoid black flashes when resizing debugger window using MSAA Avoid black flashes when resizing debugger window using MSAA. Clear the stencil buffer always after resize. Also reset the GrContext state when Qt calls resizeGL -- we do not know what GL state Qt changes. Remove setting of white background to SkGLWidget, it is not effective. QGLWidget does not respect the stylesheet. Also move the initial stencil clearing before GrContext is created in order to preserve GrContext state consistent with actual GL state. Committed: http://code.google.com/p/skia/source/detail?r=13721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M debugger/QT/SkGLWidget.cpp View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kimmo Kinnunen
6 years, 9 months ago (2014-03-10 11:46:38 UTC) #1
robertphillips
lgtm
6 years, 9 months ago (2014-03-10 11:53:44 UTC) #2
Kimmo Kinnunen
The CQ bit was checked by kkinnunen@nvidia.com
6 years, 9 months ago (2014-03-10 13:18:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/192433003/1
6 years, 9 months ago (2014-03-10 13:18:29 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 16:04:50 UTC) #5
Message was sent while issue was closed.
Change committed as 13721

Powered by Google App Engine
This is Rietveld 408576698