Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 19243002: Fix cctest/test-cpu-profiler/FunctionApplySample fakiness on ARM simulator (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
alph, Yang, loislo
CC:
v8-dev
Visibility:
Public.

Description

Fix cctest/test-cpu-profiler/FunctionApplySample fakiness on ARM simulator For STM and LDM instuctions with writeback update base register only after all registers have been saved/loaded. This guarantees that invariant sp <= fp is always true when iterating stack in the Sampler. BUG=v8:2782 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M src/arm/simulator-arm.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/arm/simulator-arm.cc View 6 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 5 months ago (2013-07-15 17:30:16 UTC) #1
Yang
On 2013/07/15 17:30:16, Yury Semikhatsky wrote: LGTM.
7 years, 5 months ago (2013-07-16 09:03:04 UTC) #2
yurys
7 years, 5 months ago (2013-07-16 09:34:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698