Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1924223002: Provide tagged allocation top pointer (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide tagged allocation top pointer BUG=chromium:606711 LOG=N

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : x64 comments #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -70 lines) Patch
M src/code-stub-assembler.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.h View 1 1 chunk +17 lines, -28 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 7 chunks +4 lines, -15 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 9 chunks +19 lines, -15 lines 0 comments Download
M test/cctest/heap/utils-inl.h View 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Michael Lippautz
wdyt? ports still missing. IIUC it would safe turbofan one instruction while all other compilers/platforms ...
4 years, 7 months ago (2016-04-28 16:58:08 UTC) #4
Hannes Payer (out of office)
looking good from my side https://codereview.chromium.org/1924223002/diff/40001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1924223002/diff/40001/src/heap/spaces.h#newcode1603 src/heap/spaces.h:1603: intptr_t top_; On 2016/04/28 ...
4 years, 7 months ago (2016-04-29 14:13:31 UTC) #5
Benedikt Meurer
Adding Enrico for the CodeStubAssembler review. The x64 port looks good, modulo the result_end thing; ...
4 years, 7 months ago (2016-05-01 17:30:04 UTC) #7
epertoso
lgtm
4 years, 7 months ago (2016-05-02 08:20:39 UTC) #8
epertoso
On 2016/05/02 at 08:20:39, epertoso wrote: > lgtm For code-stub-assembler.cc, that is.
4 years, 7 months ago (2016-05-02 08:21:03 UTC) #9
Benedikt Meurer
LGTM from my side.
4 years, 7 months ago (2016-05-03 03:58:24 UTC) #10
Benedikt Meurer
On 2016/05/03 03:58:24, Benedikt Meurer wrote: > LGTM from my side. Clicked Send too early... ...
4 years, 7 months ago (2016-05-03 03:59:41 UTC) #11
Hannes Payer (out of office)
4 years, 7 months ago (2016-05-18 18:03:59 UTC) #13
lgtm

Powered by Google App Engine
This is Rietveld 408576698