Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: appengine/findit/templates/list_analyses.html

Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/templates/list_analyses.html
diff --git a/appengine/findit/templates/list_analyses.html b/appengine/findit/templates/list_analyses.html
index 169d2a4b8865d64fbf61056cd232f9a1bb697935..2cb77e73f7d3f8dbdd21f8598d6487d1d337608b 100644
--- a/appengine/findit/templates/list_analyses.html
+++ b/appengine/findit/templates/list_analyses.html
@@ -82,10 +82,15 @@
{% for suspected_cl in analysis.suspected_cls %}
<li>
{{suspected_cl.repo_name}}:
+ {% if suspected_cl.url or suspected_cl.review_url %}
+ {% set review_url = suspected_cl.url or suspected_cl.review_url %}
+ {% else %}
+ {% set review_url = 'https://chromium.googlesource.com/chromium/src.git/+/' + suspected_cl.revision %}
+ {% endif %}
{% if suspected_cl.commit_position %}
- <a href="{{suspected_cl.url}}">{{suspected_cl.commit_position}}</a>
+ <a href="{{review_url}}">{{suspected_cl.commit_position}}</a>
{% else %}
- <a href="{{suspected_cl.url}}">{{suspected_cl.revision}}</a>
+ <a href="{{review_url}}">{{suspected_cl.revision}}</a>
{% endif %}
</li>
{% endfor %}
« no previous file with comments | « appengine/findit/templates/build_failure.html ('k') | appengine/findit/templates/waterfall/compile_failure.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698