appengine/findit/templates/build_failure.html - Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/templates/build_failure.html

Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/templates/build_failure.html

diff --git a/appengine/findit/templates/build_failure.html b/appengine/findit/templates/build_failure.html

index 06b8cb64c7b0f16dbcac5eb37f5226b4833b8dcd..52265f8892838492aa95ae3949800b2d898d2c1e 100644

--- a/appengine/findit/templates/build_failure.html

+++ b/appengine/findit/templates/build_failure.html

@@ -244,7 +244,7 @@

if (! jQuery.isEmptyObject(tryJobCulprit)) {

var build_number = result.try_job.try_job_key.split('/')[2]; // try_job_key would look like: 'master_name/builder_name/build_number'.

tableString += '<td rowspan="' + rowspan + '"><a href="' + findit.builderUrl + '/builds/' + build_number + '">' + build_number + '</a></td>';

- var review_url = tryJobCulprit.review_url || findit.defaultGitBaseUrl + 'tryJobCulprit.revision';

+ var review_url = tryJobCulprit.url || tryJobCulprit.review_url || findit.defaultGitBaseUrl + tryJobCulprit.revision;

stgao 2016/04/28 22:21:46 We'd better use review url if it is available. Sa

stgao 2016/04/28 22:21:46 Use ... || ... || (findit.defaultGitBaseUrl + tryJ

chanli 2016/04/28 22:37:34 As we discussed offline, both tryJobCulprit.url an

chanli 2016/04/28 22:37:34 Done.

tableString += '<td rowspan="' + rowspan + '"><a href="' + review_url + '">' + tryJobCulprit.commit_position || tryJobCulprit.revision + '</a></td>';

} else {

« no previous file with comments | « no previous file | appengine/findit/templates/list_analyses.html » ('j') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('J')