Use new is*Element() helper functions in accessibility code

Use new is*Element() helper functions in accessibility code

Use new is*Element() helpers in accessibility code. This makes the code clearer
and simpler. Also use the new Traversal<*Element> API where suitable.

R=eseidel, adamk
BUG=346095
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168843

[dmazzoni, 2014-03-10 15:26:38]

lgtm

https://codereview.chromium.org/192413002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXRenderObject.cpp (right):

https://codereview.chromium.org/192413002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXRenderObject.cpp:357: if
(isHTMLParagraphElement(node))
As long as we're discussing this function...I was thinking of moving this to a
hash lookup based on the AtomicString of the tag name. Pros / cons?

[dmazzoni, 2014-03-10 15:27:17]

https://codereview.chromium.org/192413002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/192413002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXNodeObject.cpp:771: return
ElementTraversal::firstChild(*node);
This is great

[Inactive, 2014-03-10 17:13:15]

https://codereview.chromium.org/192413002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXRenderObject.cpp (right):

https://codereview.chromium.org/192413002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXRenderObject.cpp:357: if
(isHTMLParagraphElement(node))
On 2014/03/10 15:26:38, dmazzoni wrote:
> As long as we're discussing this function...I was thinking of moving this to a
> hash lookup based on the AtomicString of the tag name. Pros / cons?

I think it would make sense. It would avoid all these if checks. Also, not all
tags here have a corresponding Element type and thus an is*Element() helper.

[Inactive, 2014-03-10 17:13:28]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-03-10 17:26:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192413002/1

[commit-bot: I haz the power, 2014-03-10 17:37:13]

Change committed as 168843