Source/core/accessibility/AXListBox.cpp - Issue 192413002: Use new is*Element() helper functions in accessibility code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXListBox.cpp

Issue 192413002: Use new is*Element() helper functions in accessibility code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXListBox.cpp

diff --git a/Source/core/accessibility/AXListBox.cpp b/Source/core/accessibility/AXListBox.cpp

index 444c3047fe0b10f4830c135728d70d79f13a0796..d306616316c55295841118ba1065f0a3a96692dc 100644

--- a/Source/core/accessibility/AXListBox.cpp

+++ b/Source/core/accessibility/AXListBox.cpp

@@ -126,7 +126,7 @@ void AXListBox::selectedChildren(AccessibilityChildrenVector& result)

AXObject* AXListBox::listBoxOptionAXObject(HTMLElement* element) const

{

// skip hr elements

- if (!element || element->hasTagName(hrTag))

+ if (!element || isHTMLHRElement(*element))

return 0;

AXObject* listBoxObject = m_renderer->document().axObjectCache()->getOrCreate(ListBoxOptionRole);