Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1924033003: [heap] Force inlining of AllocatedSinceLastGC (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Force inlining of AllocatedSinceLastGC Speculatively forcining inlining as not inlining potentially regresses performance. BUG=chromium:605524 LOG=N Committed: https://crrev.com/08dbdd4037aa612dc1afe40dbb073b3384b8a497 Cr-Commit-Position: refs/heads/master@{#35869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Lippautz
ptal I manually verified that the output of the old version and the new version ...
4 years, 7 months ago (2016-04-28 12:47:02 UTC) #2
Michael Lippautz
fyi: the CL that changed the implementation: https://codereview.chromium.org/1883933003
4 years, 7 months ago (2016-04-28 12:48:25 UTC) #3
ulan
lgtm
4 years, 7 months ago (2016-04-28 13:08:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924033003/1
4 years, 7 months ago (2016-04-28 13:28:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 13:51:45 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08dbdd4037aa612dc1afe40dbb073b3384b8a497
Cr-Commit-Position: refs/heads/master@{#35869}

Powered by Google App Engine
This is Rietveld 408576698