Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883933003: [heap] Optimize NewSpace::AllocatedSinceLastGC (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Optimize NewSpace::AllocatedSinceLastGC Replace page link walking with arithmetic computation. BUG=chromium:603460 LOG=N Committed: https://crrev.com/723e120bd04aeb4da5b6b5e348cb5eaf28de5c48 Cr-Commit-Position: refs/heads/master@{#35529}

Patch Set 1 #

Patch Set 2 : Fixes for same page #

Patch Set 3 : Move to -inl.h files #

Patch Set 4 : Fix offset computation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M src/heap/heap.h View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 5 chunks +11 lines, -37 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883933003/1
4 years, 8 months ago (2016-04-14 13:41:20 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/237) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 8 months ago (2016-04-14 13:57:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883933003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883933003/60001
4 years, 8 months ago (2016-04-14 14:47:04 UTC) #10
Michael Lippautz
ptal
4 years, 8 months ago (2016-04-14 14:50:57 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/162) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 8 months ago (2016-04-14 15:02:04 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883933003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883933003/80001
4 years, 8 months ago (2016-04-14 16:11:30 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 16:36:28 UTC) #18
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-15 12:58:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883933003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883933003/80001
4 years, 8 months ago (2016-04-15 12:59:35 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-15 13:02:23 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:03:56 UTC) #25
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/723e120bd04aeb4da5b6b5e348cb5eaf28de5c48
Cr-Commit-Position: refs/heads/master@{#35529}

Powered by Google App Engine
This is Rietveld 408576698