Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1923953005: Files app: Prepare all information necessary for Arc task execution. (Closed)

Created:
4 years, 7 months ago by kinaba
Modified:
4 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Prepare all information necessary for Arc task execution. Further, and hopefully the last step for refactoring needed for the feature. 1) We need mime types on the task running time as well. Added a cycle for it. 2) Split the task enumeration function for the placeholder for ARC stuff and post processing part. 3) For the efficiency and clarity for the split of 2), changed std::vector value copying to movement by std::unique_ptr. BUG=607059 TEST=unit_tests --gtest_filter='*FileManagerFileTask*' TEST=browser_tests --gtest_filter='FileManagerJsTest.FileTasks' Committed: https://crrev.com/8cdb47be03b3763ba8170a6cafbe0a0241703218 Cr-Commit-Position: refs/heads/master@{#390326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -21 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 4 chunks +49 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/open_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kinaba
4 years, 7 months ago (2016-04-28 06:51:27 UTC) #2
fukino
lgtm. Thank you!
4 years, 7 months ago (2016-04-28 07:39:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923953005/1
4 years, 7 months ago (2016-04-28 08:00:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 08:04:48 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cdb47be03b3763ba8170a6cafbe0a0241703218
Cr-Commit-Position: refs/heads/master@{#390326}

Powered by Google App Engine
This is Rietveld 408576698