chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc - Issue 1923953005: Files app: Prepare all information necessary for Arc task execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 1923953005: Files app: Prepare all information necessary for Arc task execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h ('k') | chrome/browser/chromeos/file_manager/file_tasks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

index 6431e9ecda81a1c890cd07e52013bb6ebda49646..3e7c03f8144ed617baebe7efa5f4e7bb03a6d89d 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

@@ -192,11 +192,12 @@ void FileManagerPrivateInternalGetFileTasksFunction::

}

void FileManagerPrivateInternalGetFileTasksFunction::OnFileTasksListed(

- const std::vector<file_manager::file_tasks::FullTaskDescriptor>& tasks) {

+ std::unique_ptr<std::vector<file_manager::file_tasks::FullTaskDescriptor>>

+ tasks) {

// Convert the tasks into JSON compatible objects.

using api::file_manager_private::FileTask;

std::vector<FileTask> results;

- for (const file_manager::file_tasks::FullTaskDescriptor& task : tasks) {

+ for (const file_manager::file_tasks::FullTaskDescriptor& task : *tasks) {

FileTask converted;

converted.task_id =

file_manager::file_tasks::TaskDescriptorToId(task.task_descriptor());