Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

Issue 1923943003: Add logging to remote commands (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused include Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
index fd7941032db9d23a453f27d69f06ef6bbaa6d2e5..29c15a53d0ecc78c4571bbd687752f5baa64aa2a 100644
--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
@@ -109,6 +109,7 @@ enterprise_management::RemoteCommand_Type DeviceCommandScreenshotJob::GetType()
}
void DeviceCommandScreenshotJob::OnSuccess() {
+ LOG(WARNING) << "Upload successful.";
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(succeeded_callback_,
@@ -119,10 +120,15 @@ void DeviceCommandScreenshotJob::OnFailure(UploadJob::ErrorCode error_code) {
ResultCode result_code = FAILURE_CLIENT;
switch (error_code) {
case UploadJob::AUTHENTICATION_ERROR:
+ LOG(ERROR) << "Upload failure: authentication error.";
Andrew T Wilson (Slow) 2016/05/04 14:43:22 Just have one log that is "Upload failure: " << er
Marton Hunyady 2016/05/09 13:48:15 Done.
result_code = FAILURE_AUTHENTICATION;
break;
case UploadJob::NETWORK_ERROR:
+ LOG(ERROR) << "Upload failure: network error.";
+ result_code = FAILURE_SERVER;
+ break;
case UploadJob::SERVER_ERROR:
+ LOG(ERROR) << "Upload failure: server error.";
result_code = FAILURE_SERVER;
break;
}
@@ -190,8 +196,11 @@ void DeviceCommandScreenshotJob::RunImpl(
succeeded_callback_ = succeeded_callback;
failed_callback_ = failed_callback;
+ LOG(WARNING) << "Executing screenshot command.";
+
// Fail if the delegate says screenshots are not allowed in this session.
if (!screenshot_delegate_->IsScreenshotAllowed()) {
+ LOG(ERROR) << "Screenshots are not allowed.";
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(failed_callback_, base::Passed(base::WrapUnique(
@@ -212,6 +221,7 @@ void DeviceCommandScreenshotJob::RunImpl(
// Immediately fail if there are no attached screens.
if (root_windows.size() == 0) {
+ LOG(ERROR) << "No attached screens.";
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(failed_callback_, base::Passed(base::WrapUnique(new Payload(

Powered by Google App Engine
This is Rietveld 408576698