Add logging to remote commands

chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h"
 
 #include <fstream>
 #include <utility>
 
 #include "ash/shell.h"
@@ skipping 91 matching lines @@
 
 DeviceCommandScreenshotJob::~DeviceCommandScreenshotJob() {
 }
 
 enterprise_management::RemoteCommand_Type DeviceCommandScreenshotJob::GetType()
     const {
   return enterprise_management::RemoteCommand_Type_DEVICE_SCREENSHOT;
 }
 
 void DeviceCommandScreenshotJob::OnSuccess() {
+  LOG(WARNING) << "Upload successful.";
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE,
       base::Bind(succeeded_callback_,
                  base::Passed(base::WrapUnique(new Payload(SUCCESS)))));
 }
 
 void DeviceCommandScreenshotJob::OnFailure(UploadJob::ErrorCode error_code) {
   ResultCode result_code = FAILURE_CLIENT;
   switch (error_code) {
     case UploadJob::AUTHENTICATION_ERROR:
+      LOG(ERROR) << "Upload failure: authentication error.";

[Andrew T Wilson (Slow), 2016/05/04 14:43:22]

Just have one log that is "Upload failure: " << error_code. That is sufficient.

[Marton Hunyady, 2016/05/09 13:48:15]

Done.

       result_code = FAILURE_AUTHENTICATION;
       break;
     case UploadJob::NETWORK_ERROR:
+      LOG(ERROR) << "Upload failure: network error.";
+      result_code = FAILURE_SERVER;
+      break;
     case UploadJob::SERVER_ERROR:
+      LOG(ERROR) << "Upload failure: server error.";
       result_code = FAILURE_SERVER;
       break;
   }
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE,
       base::Bind(failed_callback_,
                  base::Passed(base::WrapUnique(new Payload(result_code)))));
 }
 
 bool DeviceCommandScreenshotJob::IsExpired(base::TimeTicks now) {
@@ skipping 47 matching lines @@
   }
   upload_job_->Start();
 }
 
 void DeviceCommandScreenshotJob::RunImpl(
     const CallbackWithResult& succeeded_callback,
     const CallbackWithResult& failed_callback) {
   succeeded_callback_ = succeeded_callback;
   failed_callback_ = failed_callback;
 
+  LOG(WARNING) << "Executing screenshot command.";
+
   // Fail if the delegate says screenshots are not allowed in this session.
   if (!screenshot_delegate_->IsScreenshotAllowed()) {
+    LOG(ERROR) << "Screenshots are not allowed.";
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(failed_callback_, base::Passed(base::WrapUnique(
                                          new Payload(FAILURE_USER_INPUT)))));
   }
 
   aura::Window::Windows root_windows = ash::Shell::GetAllRootWindows();
 
   // Immediately fail if the upload url is invalid.
   if (!upload_url_.is_valid()) {
     LOG(ERROR) << upload_url_ << " is not a valid URL.";
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(failed_callback_, base::Passed(base::WrapUnique(
                                          new Payload(FAILURE_INVALID_URL)))));
     return;
   }
 
   // Immediately fail if there are no attached screens.
   if (root_windows.size() == 0) {
+    LOG(ERROR) << "No attached screens.";
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(failed_callback_, base::Passed(base::WrapUnique(new Payload(
                                          FAILURE_SCREENSHOT_ACQUISITION)))));
     return;
   }
 
   upload_job_ = screenshot_delegate_->CreateUploadJob(upload_url_, this);
   DCHECK(upload_job_);
 
@@ skipping 10 matching lines @@
                               weak_ptr_factory_.GetWeakPtr(), screen),
                    base::ThreadTaskRunnerHandle::Get()));
   }
 }
 
 void DeviceCommandScreenshotJob::TerminateImpl() {
   weak_ptr_factory_.InvalidateWeakPtrs();
 }
 
 }  // namespace policy