Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1923783002:
Include Closure Compiler in CQ bots for various resource directories (Closed)
|
Created:
4 years, 8 months ago by Dan Beam Modified:
4 years, 7 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInclude Closure Compiler in CQ bots for various resource directories
This adds:
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
to CLs in ui/webui/resources or chrome/browse/resources.
R=dpranke@chromium.org
BUG=468366
Committed: https://crrev.com/130118b33aedccfb976ad90a0a63814411c31c63
Cr-Commit-Position: refs/heads/master@{#390839}
Patch Set 1 : asdf #
Messages
Total messages: 43 (38 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_EXTRA_TRYBOTS=blah;blee ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_EXTRA_TRYBOTS=blah;blee ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=blah;blee ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=blah;blee ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=blee;blah;tryserver.chromium.linux:closure_compilation ==========
Patchset #3 (id:60001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=blee;blah;tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=a ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=a ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=n;_;a;c;e;i;h;m;l;o;.;p;s;r;u;t;v;y;x;: ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=n;_;a;c;e;i;h;m;l;o;.;p;s;r;u;t;v;y;x;: ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=a ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=a ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=a;tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=a;tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=n;_;a;c;e;i;h;m;l;o;.;p;s;r;u;t;v;y;x;: ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=n;_;a;c;e;i;h;m;l;o;.;p;s;r;u;t;v;y;x;: ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;.;_;a;c;e;i;h;m;l;o;n;p;s;r;u;t;v;y;x;: ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;.;_;a;c;e;i;h;m;l;o;n;p;s;r;u;t;v;y;x;: ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=blah ; bleeeeee ; ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=blah ; bleeeeee ; ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=bleeeeee;blah;tryserver.chromium.linux:closure_compilation ==========
Patchset #2 (id:100001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:120001) has been deleted
Patchset #2 (id:160001) has been deleted
Patchset #2 (id:180001) has been deleted
Patchset #3 (id:210001) has been deleted
Patchset #3 (id:230001) has been deleted
Patchset #3 (id:250001) has been deleted
Patchset #3 (id:270001) has been deleted
Patchset #2 (id:190001) has been deleted
Patchset #1 (id:140001) has been deleted
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 CQ_INCLUDE_TRYBOTS=bleeeeee;blah;tryserver.chromium.linux:closure_compilation ========== to ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs that touch ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs that touch ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs that touch ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ==========
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs that touch ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ==========
this more-or-less lgtm , assuming we get the compilation bot working stably.
The CQ bit was checked by dbeam@chromium.org
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923783002/240003 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923783002/240003
Message was sent while issue was closed.
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:240003)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/130118b33aedccfb976ad90a0a63814411c31c63 Cr-Commit-Position: refs/heads/master@{#390839}
Message was sent while issue was closed.
Description was changed from ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 ========== to ========== Include Closure Compiler in CQ bots for various resource directories This adds: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation to CLs in ui/webui/resources or chrome/browse/resources. R=dpranke@chromium.org BUG=468366 Committed: https://crrev.com/130118b33aedccfb976ad90a0a63814411c31c63 Cr-Commit-Position: refs/heads/master@{#390839} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
