Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 1923783002: Include Closure Compiler in CQ bots for various resource directories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: asdf Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/PRESUBMIT.py
diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py
index 502d47a88d2580cac3d35013a8ae49c8922886cb..6d60a3a922829212ccbaaba2e03fa37454310b48 100644
--- a/chrome/browser/resources/PRESUBMIT.py
+++ b/chrome/browser/resources/PRESUBMIT.py
@@ -2,14 +2,18 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Presubmit script for HTML files in chrome/browser/resources.
+"""Presubmit script for files in chrome/browser/resources.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
"""
+import re
+
+
ACTION_XML_PATH = '../../../tools/metrics/actions/actions.xml'
+
def CheckUserActionUpdate(input_api, output_api, action_xml_path):
"""Checks if any new user action has been added."""
if any('actions.xml' == input_api.os_path.basename(f) for f in
@@ -93,3 +97,26 @@ def CheckChangeOnUpload(input_api, output_api):
def CheckChangeOnCommit(input_api, output_api):
return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
+
+
+def PostUploadHook(cl, change, output_api):
+ rietveld_obj = cl.RpcServer()
+ description = rietveld_obj.get_description(cl.issue)
+
+ existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')
+ clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))
+ new_bots = clean_bots | set(['tryserver.chromium.linux:closure_compilation'])
+ new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)
+
+ if clean_bots:
+ tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'
+ new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I)
+ else:
+ new_description = description + '\n' + new_tag
+
+ if new_description == description:
+ return []
+
+ rietveld_obj.update_description(cl.issue, new_description)
+ return [output_api.PresubmitNotifyResult(
+ 'Automatically added optional Closure bots to run on CQ.')]
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698