Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192373004: use SkColorType instead of (deprecated) SkBitmap::Config for copyTo (Closed)

Created:
6 years, 9 months ago by reed2
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

use SkColorType instead of (deprecated) SkBitmap::Config for copyTo TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255918

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -115 lines) Patch
M cc/layers/heads_up_display_layer_impl.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 1 1 chunk +1 line, -9 lines 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/bitmap_content_layer_updater.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M cc/resources/picture_pile_impl_unittest.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 4 chunks +22 lines, -29 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download
M cc/resources/resource_update_controller_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/ui_resource_bitmap.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/ui_resource_bitmap.cc View 1 2 chunks +12 lines, -1 line 0 comments Download
M cc/test/fake_scoped_ui_resource.cc View 1 1 chunk +1 line, -7 lines 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
reed1
6 years, 9 months ago (2014-03-10 01:44:16 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-10 02:40:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/192373004/1
6 years, 9 months ago (2014-03-10 02:40:29 UTC) #3
reed1
I think it is sufficient for this CL to pass the ui_unittests on windows...
6 years, 9 months ago (2014-03-10 03:05:00 UTC) #4
reed1
doh -- disregard just needing ui_unittests. All win bots should be considered.
6 years, 9 months ago (2014-03-10 03:05:55 UTC) #5
hal.canary
lgtm
6 years, 9 months ago (2014-03-10 03:41:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 06:18:53 UTC) #7
commit-bot: I haz the power
List of reviewers changed. rmistry@chromium.org did a drive-by without LGTM'ing!
6 years, 9 months ago (2014-03-10 06:18:54 UTC) #8
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-10 12:13:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/192373004/1
6 years, 9 months ago (2014-03-10 12:13:48 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 12:17:12 UTC) #11
Message was sent while issue was closed. 
Change committed as 255918

Powered by Google App Engine
This is Rietveld 408576698