cc/output/renderer_pixeltest.cc - Issue 192373004: use SkColorType instead of (deprecated) SkBitmap::Config for copyTo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/renderer_pixeltest.cc

Issue 192373004: use SkColorType instead of (deprecated) SkBitmap::Config for copyTo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/renderer_pixeltest.cc

diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc

index 1165f9a988cdfe6c58e86d82f4a4318f9b255391..1511db95bc12cd6f6d758f02e5092284acc0e13d 100644

--- a/cc/output/renderer_pixeltest.cc

+++ b/cc/output/renderer_pixeltest.cc

@@ -1805,8 +1805,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadDisableImageFiltering) {

CreateTestRenderPass(id, viewport, transform_to_root);

SkBitmap bitmap;

- bitmap.setConfig(SkBitmap::kARGB_8888_Config, 2, 2);

- bitmap.allocPixels();

+ bitmap.allocN32Pixels(2, 2);

{

SkAutoLockPixels lock(bitmap);

SkCanvas canvas(bitmap);

« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/resources/bitmap_content_layer_updater.cc » ('j') | no next file with comments »