chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc - Issue 1923653002: Wire up process launch error codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc

Issue 1923653002: Wire up process launch error codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix debug and clang Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc ('k') | chrome/browser/image_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc

index 891cd448468e53b0a78afbffabd139a39a73979f..fb624e216a9ecad3e172bdb838c0b60993578739 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc

@@ -10,6 +10,7 @@

#include "base/bind.h"

#include "base/macros.h"

#include "base/strings/string_piece.h"

+#include "base/strings/stringprintf.h"

#include "base/thread_task_runner_handle.h"

#include "base/threading/sequenced_worker_pool.h"

#include "chrome/common/extensions/api/networking_private/networking_private_crypto.h"

@@ -34,7 +35,7 @@ class CredentialsGetterHostClient : public UtilityProcessHostClient {

// UtilityProcessHostClient

bool OnMessageReceived(const IPC::Message& message) override;

void OnProcessCrashed(int exit_code) override;

- void OnProcessLaunchFailed() override;

+ void OnProcessLaunchFailed(int error_code) override;

// IPC message handlers.

void OnGotCredentials(const std::string& key_data, bool success);

@@ -72,11 +73,13 @@ bool CredentialsGetterHostClient::OnMessageReceived(

}

void CredentialsGetterHostClient::OnProcessCrashed(int exit_code) {

- callback_.Run("", "Process Crashed");

+ callback_.Run(

+ "", base::StringPrintf("Process Crashed with code %08x.", exit_code));

}

-void CredentialsGetterHostClient::OnProcessLaunchFailed() {

- callback_.Run("", "Process Launch Failed");

+void CredentialsGetterHostClient::OnProcessLaunchFailed(int error_code) {

+ callback_.Run("", base::StringPrintf("Process Launch Failed with code %08x.",

+ error_code));

}

void CredentialsGetterHostClient::OnGotCredentials(const std::string& key_data,