Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

Issue 1923653002: Wire up process launch error codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix debug and clang Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
index d60993f8242f32a30e684e17741f94cc67d523a3..1c64b4a6adeab5c7d8e7cc2ae73539495c955088 100644
--- a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
@@ -4,6 +4,7 @@
#include "base/bind.h"
#include "base/location.h"
+#include "base/strings/stringprintf.h"
#include "base/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
@@ -109,12 +110,18 @@ void ImageWriterUtilityClient::StartHost() {
void ImageWriterUtilityClient::OnProcessCrashed(int exit_code) {
task_runner_->PostTask(
- FROM_HERE, base::Bind(error_callback_, "Utility process crashed."));
+ FROM_HERE,
+ base::Bind(error_callback_,
+ base::StringPrintf("Utility process crashed with code %08x.",
+ exit_code)));
}
-void ImageWriterUtilityClient::OnProcessLaunchFailed() {
+void ImageWriterUtilityClient::OnProcessLaunchFailed(int error_code) {
task_runner_->PostTask(
- FROM_HERE, base::Bind(error_callback_, "Process launch failed."));
+ FROM_HERE,
+ base::Bind(error_callback_,
+ base::StringPrintf("Process launch failed with code %08x.",
+ error_code)));
}
bool ImageWriterUtilityClient::OnMessageReceived(const IPC::Message& message) {

Powered by Google App Engine
This is Rietveld 408576698