Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1923593003: Add mus::mojom::ChannelHandle for passing IPC::ChannelHandle via mojo IPC. (Closed)

Created:
4 years, 8 months ago by Peng
Modified:
4 years, 7 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mus::mojom::ChannelHandle for passing IPC::ChannelHandle via mojo IPC. BUG=586377 Committed: https://crrev.com/b5487ec0b21599f2df853b65e1f63df43da9c820 Cr-Commit-Position: refs/heads/master@{#390552}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Total comments: 4

Patch Set 4 : Update #

Patch Set 5 : update #

Total comments: 6

Patch Set 6 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -1 line) Patch
M components/mus/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gpu/BUILD.gn View 1 1 chunk +38 lines, -0 lines 0 comments Download
M components/mus/gpu/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A components/mus/gpu/gpu_type_converters.h View 1 chunk +29 lines, -0 lines 0 comments Download
A components/mus/gpu/gpu_type_converters.cc View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A components/mus/gpu/gpu_type_converters_unittest.cc View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
A components/mus/gpu/mus_gpu_unittests_app_manifest.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/mus/public/interfaces/channel_handle.mojom View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Peng
Hi Fady, PTAL. Thanks.
4 years, 7 months ago (2016-04-27 17:54:20 UTC) #2
Fady Samuel
https://codereview.chromium.org/1923593003/diff/40001/components/mus/gpu/DEPS File components/mus/gpu/DEPS (right): https://codereview.chromium.org/1923593003/diff/40001/components/mus/gpu/DEPS#newcode2 components/mus/gpu/DEPS:2: "+gpu", I'd prefer to make sure we don't end ...
4 years, 7 months ago (2016-04-27 18:05:23 UTC) #3
Peng
https://codereview.chromium.org/1923593003/diff/40001/components/mus/gpu/DEPS File components/mus/gpu/DEPS (right): https://codereview.chromium.org/1923593003/diff/40001/components/mus/gpu/DEPS#newcode2 components/mus/gpu/DEPS:2: "+gpu", On 2016/04/27 18:05:23, Fady Samuel wrote: > I'd ...
4 years, 7 months ago (2016-04-27 18:29:00 UTC) #4
Fady Samuel
components/mus/gpu LGTM
4 years, 7 months ago (2016-04-27 20:09:23 UTC) #5
Peng
Hi sky, PTAL. Thanks.
4 years, 7 months ago (2016-04-27 20:11:11 UTC) #7
sky
https://codereview.chromium.org/1923593003/diff/80001/components/mus/public/interfaces/channel_handle.mojom File components/mus/public/interfaces/channel_handle.mojom (right): https://codereview.chromium.org/1923593003/diff/80001/components/mus/public/interfaces/channel_handle.mojom#newcode7 components/mus/public/interfaces/channel_handle.mojom:7: // import "components/mus/public/interfaces/command_buffer.mojom"; ? https://codereview.chromium.org/1923593003/diff/80001/components/mus/public/interfaces/channel_handle.mojom#newcode9 components/mus/public/interfaces/channel_handle.mojom:9: struct ChannelHandle { ...
4 years, 7 months ago (2016-04-27 21:11:21 UTC) #8
Peng
https://codereview.chromium.org/1923593003/diff/80001/components/mus/public/interfaces/channel_handle.mojom File components/mus/public/interfaces/channel_handle.mojom (right): https://codereview.chromium.org/1923593003/diff/80001/components/mus/public/interfaces/channel_handle.mojom#newcode7 components/mus/public/interfaces/channel_handle.mojom:7: // import "components/mus/public/interfaces/command_buffer.mojom"; On 2016/04/27 21:11:21, sky wrote: > ...
4 years, 7 months ago (2016-04-27 22:09:40 UTC) #9
sky
LGTM
4 years, 7 months ago (2016-04-28 23:23:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923593003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923593003/100001
4 years, 7 months ago (2016-04-28 23:23:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/62400)
4 years, 7 months ago (2016-04-28 23:58:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923593003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923593003/100001
4 years, 7 months ago (2016-04-28 23:59:51 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-04-29 01:16:48 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:10 UTC) #19
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/b5487ec0b21599f2df853b65e1f63df43da9c820
Cr-Commit-Position: refs/heads/master@{#390552}

Powered by Google App Engine
This is Rietveld 408576698