Chromium Code Reviews| Index: remoting/test/counter_stubs.h |
| diff --git a/remoting/test/counter_stubs.h b/remoting/test/counter_stubs.h |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a096c4f47036b6f17072aa7c329d94700bd250f0 |
| --- /dev/null |
| +++ b/remoting/test/counter_stubs.h |
| @@ -0,0 +1,39 @@ |
| +// Copyright 2016 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
|
joedow
2016/05/04 16:40:44
Please add macro guard.
Hzj_jie
2016/05/04 19:18:04
Done.
|
| +#include <memory> |
| +#include <ostream> |
| + |
| +#include "remoting/protocol/audio_stub.h" |
| +#include "remoting/protocol/client_stub.h" |
| +#include "remoting/protocol/fake_connection_to_client.h" |
| +#include "remoting/protocol/host_stub.h" |
| +#include "remoting/protocol/video_stub.h" |
| + |
| +namespace remoting { |
| +namespace test { |
| + |
| +class CounterStubs { |
|
joedow
2016/05/04 16:40:44
Can you make this name more descriptive? It seems
Hzj_jie
2016/05/04 19:18:04
Done.
|
| + public: |
| + CounterStubs(protocol::FakeConnectionToClient* connection = nullptr); |
|
joedow
2016/05/04 16:40:44
single param c'tors should be defined as 'explicit
Hzj_jie
2016/05/04 19:18:04
Done.
|
| + virtual ~CounterStubs(); |
|
joedow
2016/05/04 16:40:44
newline between c'tor/d'tor and getter methods
Hzj_jie
2016/05/04 19:18:04
Done.
|
| + protocol::ClientStub& client_stub(); |
| + protocol::HostStub& host_stub(); |
| + protocol::AudioStub& audio_stub(); |
| + protocol::VideoStub& video_stub(); |
| + friend std::ostream& operator<<(std::ostream& os, const CounterStubs& stubs); |
| + |
| + private: |
| + class CounterClientStub; |
| + class CounterHostStub; |
| + class CounterAudioStub; |
| + class CounterVideoStub; |
|
joedow
2016/05/04 16:40:44
newline between class forward decls and members.
Hzj_jie
2016/05/04 19:18:04
Done.
|
| + std::unique_ptr<CounterClientStub> client_stub_; |
| + std::unique_ptr<CounterHostStub> host_stub_; |
| + std::unique_ptr<CounterAudioStub> audio_stub_; |
| + std::unique_ptr<CounterVideoStub> video_stub_; |
|
joedow
2016/05/04 16:40:45
DISALLOW_COPY_AND_ASSIGN(...)?
Hzj_jie
2016/05/04 19:18:04
Done.
|
| +}; |
| + |
| +} // namespace test |
| +} // namespace remoting |